fix coverity "bug" 184 (false positive)

the contract for wiretap ..._read() functions are that the *err pointer MUST always
be provided as a valid pointer and not a NULL pointer.


ber.c contained a spurios and redundant check for the pointer being non-NULL wich triggered coverity to detect this as a false positive.

this redundant test if the pointer is NULL has been revoved.



svn path=/trunk/; revision=18492
This commit is contained in:
Ronnie Sahlberg 2006-06-17 10:26:20 +00:00
parent d8e1827401
commit 22edbe1066
1 changed files with 1 additions and 2 deletions

View File

@ -83,8 +83,7 @@ static gboolean ber_read(wtap *wth, int *err, gchar **err_info, long *data_offse
wth->phdr.len = packet_size;
if (fstat(wth->fd, &statb) == -1) {
if (err != NULL)
*err = errno;
*err = errno;
return FALSE;
}