From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :
I'd like to share my enhancements to the TDS dissector with everyone. The list of improvements follows: - nearly complete dissection of RPC calls, - detection and dissection of the ALL_HEADERS rule, - corrected some existing proto_tree fields to support filters, - other minor fixes where the interpretation of data conflicted with the official documentation from MS. I tested the new code on a variety of different TDS captures with many diverse RPC calls. The code compiles and works on 32-bit Linux, I didn't check those changes on other platforms though. From me: - terminate all value_strings - change ++*offset to *offset += 1 (I think that's more readable) - replace all the dissector assertions which could be caused by malformed packets with expert infos - Don't throw ReportedBoundsError when the packets have unexpected data in them, just report an expert info and continue on svn path=/trunk/; revision=35007
This commit is contained in:
parent
cf794aea59
commit
1b04b1b765