This member is deprcated/unused so simply remove it:
> 'is_config_node' is deprecated: Implicit parent node tracking has
> replaced the use of this callback. This callback is no longer called,
> ever, and can be left NULL.
Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82
tall_ctr_ctx is only used by the obsolete osmo_counters which are not
used anymore.
tall_msgb_ctx is now set through msgb_tallox_ctx_init().
Fixes undefined reference errors since libosmocore.map was introduced in
I13169c00a59fb59513dfc598de5a71d094492422:
```
osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx'
/usr/bin/ld: osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx'
/usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx'
/usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx'
```
Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f
By default systemd will execute service with root directory
(or home directory for user instance) which might result in
attempts to create files in unexpected place. Let's set it
to 'osmocom' subdir of state directory
(/var/lib for system instance) instead.
Related: OS#4821
Change-Id: I39c48167cbe74b599c8edc3659e787792cbcfdfd
This allows setting a suitable write-queue max length per client. The
desired value can be different based on a lot of variables, like memory
availabilty, network and CPU load, input/output link state, etc.
Related: SYS#5921
Change-Id: I4e9d5d836ddda215f9e7a075aa8e10d2d3854dd2
Having a length of 10 packets is too low, it can be filled easily under
high load or really bursty traffic, where the input path could be polled
multiple times while the output path (write socket poll) is not called.
Related: SYS#5921
Change-Id: I72babfcc31e12624f30c16450dafd988192148be
gprs header files from libosmogb are needed for osmo-pcap. This was the
reason why it was added as dependency to configure.ac in
I9a8fa03cef1efc9fdaea65ee63ca9b3379993989.
$ git grep "osmocom/gprs"
src/osmo_client_core.c:#include <osmocom/gprs/gprs_bssgp.h>
src/osmo_client_core.c:#include <osmocom/gprs/protocol/gsm_08_16.h>
src/osmo_client_core.c:#include <osmocom/gprs/protocol/gsm_08_18.h>
The package is only still building for debian, because in debian
libosmocore is not split up, and for centos, because the rpm spec file
still lists the dependency.
This reverts commit 2c2eadcadf.
Change-Id: Ic358956521230a2f6525533779c27417b2e86833
the spec.in files already stated so expicitly, since some files include
osmocom/gprs/*.h. Only some data types from there are used, so there's
no need in linking the lib. Even more, doing so makes the build fail
because there soft-linking symbols required to be implemented by
libosmogb are not implemented here.
Related: OS#5311
Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989
Resolve conflict with other Osmocom software by moving ports:
osmo-pcap-client 4237 -> 4227
osmo-pcap-server 4238 -> 4228
Notably the defines OSMO_VTY_PORT_PCAP_CLIENT and _SERVER are currently
not provided by libosmocore, but will be added with the related commit.
Related: OS#5203
Related: libosmocore I098f211370bba61995ce424ab64029bdd4c49e2d
Change-Id: I3b18b1fbbca2799f868f28104e2f5d513f93d46c
In case the config file specifies a vty bind address, we must read
it before we start the telnet server.
Change-Id: I44561754d4beaad5c74cb66994ca4ef38960ea78
Prior to this patch, you could configure 'bind 1.2.3.4' in the
config file, but the telnet interface still binds to 127.0.0.1.
Change-Id: I9b86b2cf6949917c55ea15277619cfa2b745185d
A non-blocking STREAM socket connect() will mark the socket as
write-able once the connection succeeds. However, as we first
call osmo_fd_setup() and then osmo_sock_init2_ofd(), the latter
will force the 'when' to OSMO_FD_READ and hence the write callback
will not be called.
Change-Id: I44c484b48966a985a9b85fb16122a17df5666bc1
Currently `make publish` fails on Jenkins because there is nothing
to publish. In [1] we simply forgot to pass '--enable-manuals'
if $WITH_MANUALS is set to 1, so no PDFs are built. Fix this.
Change-Id: I85dfecf2025a0466fccfe5a1e63cda788f85992e
Fixes: [1] I28353f51de798535a3bb6efdc6c2da443d96ddfb
This adds one common user manual for both osmo-pcap-client
and osmo-pcap-server.
The manual is still basic in nature, but already contains useful
information regarding the setup of both clients and servers.
Change-Id: I66182fc55f1ee323eba45e7a7fc59db55bff520e
If we have more than one dependency in the line, osmo-release.sh
fails with
ERROR: configure.ac <libosmocore, 0.11.0> does NOT match debian/control <Build-Depends:debhelper, 7.0.50~dh-autoreconfautotools-devlibpcap0.8-devpkg-configlibosmocore-devlibgnutls28-devlibzmq3-dev>!
Change-Id: I8ab9a24af6ac0e4610ecc0eca1d5f5b9e03ad445
Previous code relied on abort() switching sigaction to SIG_FDL +
retriggering SIGABRT in case the signal handler returns, which would
then generate the coredump + terminate the process.
However, if a SIGABRT is received from somewhere else (kill -SIGABRT),
then the process would print the talloc report and continue running,
which is not desired.
Fixes: OS#4865
Change-Id: I39367aa480445fe961dcfa308789b3fc0cf759a1
Vadim Yanitskiy
Andreas Eversberg
Pau Espin
Oliver Smith
Daniel Willmann
Harald Welte
Joachim Steiger