Commit Graph

7 Commits

Author SHA1 Message Date
Oliver Smith a7df704d4d scripts/docker-cleanup: fix timing problems
Don't delete images while they are being used, to fix these errors we
see from time to time in the middle of "docker build" on jenkins:
unknown parent image ID sha256:1b072e35048cd8b680eddabdc641ac678edb1184d222d5e7b3fbe0b3c333129a

This happens because "docker build" creates so-called dangling images
for each step processed of a Dockerfile. The "docker system prune" call
deletes these dangling images (among other things).

Remove the "docker system prune" call. We already have the docuum daemon
to deal with unused images (dangling and not dangling), it removes them
based on last use date so that the used space is always below a
configured limit. As it deletes images that haven't been used the
longest when it reaches the limit, it will not result in the problem
explained above.

Besides images, "docker system prune" also removes unused containers
(instances of images created with 'docker run' without --rm) and
networks. Add "docker container prune" and "docker network prune"
commands to remove them from now on.

Also remove the redundant container removal logic (previous it was
redundant with "docker system prune", now redundant with "docker
container prune").

Related: https://docs.docker.com/config/pruning/
Change-Id: Ia1b466eea43dd135373949e8e3e6b005c169ea0c
2022-12-09 10:40:33 +01:00
Oliver Smith 88521fbc14 scripts/docker-cleanup.sh: conditional img clean
Only run the simple image clean code if docuum is not running. It works
well enough in most cases, but has the drawbacks that it never deletes
"latest" images or images not matching "^osmocom-build", and may delete
images that are still being used (OS#5447). With the other tool, all
images are considered for removal, and the ones that have not been used
the longest time are removed first.

Related: OS#5477, OS#5066, SYS#5827
Change-Id: I1cef0833c096de0fa5acf77156bb5dd362e2ef9c
2022-02-11 15:44:44 +01:00
Oliver Smith b5ebf6ea6b scripts/docker-cleanup.sh: use "docker system prune"
Do not only clean up dangling images, but also containers, volumes and
networks.

Related: SYS#5827
Change-Id: If441b251de50063f0229d36fb1bc260a4cb1dd87
2022-02-11 15:44:16 +01:00
Oliver Smith 2b77e64c48 scripts/docker-cleanup.sh: delete containers too
Related: SYS#5827
Change-Id: I73b2f13875286c1aaa5424809edab2202f41768b
2022-02-11 15:44:16 +01:00
Oliver Smith e94b29e837 scripts/docker-cleanup.sh: use set -x
Change-Id: Iba170128e55a9778467c3d3bcf33a91321a8c29f
2022-02-11 15:44:16 +01:00
Alexander Couzens bd20389e49 scripts/docker-cleanup.sh: set permissions to 755
It will otherwise not executed by the cron, because the cron
is checking for the executable bit

Change-Id: Ie9d67b157d62b38b62f5e74406d14344f90d07b8
2018-04-16 16:33:08 +02:00
Harald Welte acdde1617b add docker-cleanup.sh script
This script should be executed regularly on all build slaves that
have docker in order to discard unused images/layers.  It would
be a good idea to call "fstrim /" afterwards in order to get more
SSD performance.  However, the latter requires root access, and hence
cannot be called by the 'osmocom-build' user and thus jenkins.

Maybe we should install it as a cron job or systemd periodic timer job?

Related: OS#3144
Change-Id: I688b952578507a9cc28fe682221b5c7e3a245519
2018-04-11 06:07:12 +00:00