Since recently [1] osmo-upf depends on libosmo-{gtlv,pfcp}.so, which
are provided by libosmo-pfcp.git. We need to build libosmo-pfcp
before attempting to build osmo-upf, otherwise it fails:
configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met:
Package libosmo-gtlv was not found in the pkg-config search path.
Perhaps you should add the directory containing `libosmo-gtlv.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libosmo-gtlv', required by 'world', not found
Change-Id: Ic4fe7b40cf9a57e0462b2c0806f8810fcc04a10c
'make check' does not pass for asn1c, it fails with the following. I
looked into it and the cause is not obvious to me, so in order to make
the jenkins job pass again I've changed it back to just run 'make'
instead.
Fix for:
...
fatal: making test-suite.log: failed to create ../tests/98-attribute-class-OK.asn1.log
fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.trs
fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.log
Makefile:735: recipe for target 'test-suite.log' failed
make[3]: *** [test-suite.log] Error 1
make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/asn1c/libasn1fix'
Makefile:841: recipe for target 'check-TESTS' failed
Disable 'make check' for libusrp too as it also didn't pass:
Making check in usrp2
make[4]: Entering directory '/tmp/coverity/source-Osmocom/libusrp/firmware/src/usrp2'
test -f `basename 'eeprom_boot.a51'` || ln -s 'eeprom_boot.a51' .
test -f ../common/`basename 'eeprom_boot.a51'` -o \
\! -f `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` \
|| ln -s `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` ../common/`basename 'eeprom_boot.a51'`
sdas8051 -plosgff `basename 'eeprom_boot.a51'`
sdcc -mmcs51 --no-xinit-opt -I../../../firmware/include -I../../../firmware/src/usrp2 -I../../../firmware/src/common -I../../../firmware/src/common -DHAVE_USRP2 \
-c -o eeprom_init.rel `test -f 'eeprom_init.c' || echo './'`eeprom_init.c
test -f `basename '_startup.a51'` || ln -s '_startup.a51' .
test -f ../common/`basename '_startup.a51'` -o \
\! -f `dirname '_startup.a51'`/../common/`basename '_startup.a51'` \
|| ln -s `dirname '_startup.a51'`/../common/`basename '_startup.a51'` ../common/`basename '_startup.a51'`
sdas8051 -plosgff `basename '_startup.a51'`
make[4]: *** No rule to make target '../../lib/libfx2.lib', needed by 'eeprom_boot.ihx'. Stop.
All other 'make check' calls do work as expected, the build script runs
through again with this patch.
Fixes: bf84ba9f ("coverity/build_Osmocom.sh: run 'make check' in do_build()")
Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270
This enables building and running tests (check_PROGRAMS), so that
Coverity will be able to find bugs in their code too.
Change-Id: I3f3149a61df96646798c72d0ad31c41b97e6b81f
Starting from I57e77f927ee9e169cc794c5dc6b128a2d590201b, autotools
are required in order to configure and build the project.
Change-Id: I48696af1ccb5eb884f5de9085bcda37fc41766fb
Fixes: I74da8b523c9d51887d5eceb01ca0f505bb846812
We have parallel build enabled in libsmpp34.git since 2018.
Change-Id: Ibe57a8c823d9b35e2f51c9bd7a13d6baf61bf0ca
Related: Id41fbcb5a96093eb6c3dc00bcacbd379111ada70
Because the systemd install directory does not use --prefix as
base, they are installed by default to /lib/systemd.
As the coverity only scans the compilation, don't install systemd files.
Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
It was disabled back in a days when it was dependent on a separate
branch. Thisis no longer the case so we can enable it back. Also remove
remaining leftovers.
Change-Id: I5fd3bdab217b61f9ee50a5f1413b60d396535395
The OpenBSC codebase only receive occasional backports hence none of the
issues uncovered by Coverity would be fixed unless it's also fixed in
corresponding Osmo* project. Let's not clutter output with the
information about issues which won't be fixed anyway.
Change-Id: Ief3dfc641684fa33407957bf7cfcb6ecf35b847a
We don't need a separate build_foo function if it is identical in
its body except for the 'foo' (project name). Let's clean this up.
Change-Id: I27e9fc94142b42a7b7c2f9eca89056e1f90f1f0e
* use coverity check on osmo-ggsn instead of openggsn
* move osmo-sgsn and osmo-ggsn from nightly-split into nightly
Change-Id: Ia49969cbfb9ef57b635a3b5759f411f71a54f8e1
Rebasing the iu branches onto the master branches is currently not happening
regularly, since I'm focusing on the VLR. Rather scan the master branches so
that the coverity issues are caught without further rebase effort required.
Comment out everything Iu related with '#IU' comment markers:
- don't checkout Iu branches
- don't build osmo-iuh (depends on libosmo-sccp iu branch)
- don't pass --enable-iu to openbsc, don't switch branches for osmo-bts
We might consider adding a separate Iu build, but then we might get the same
coverity warnings twice, so not pursuing that actively now.
Change-Id: I0d6640b893b8d65d321af904b80d89da5bf3ea6a
This corresponds to the scan.coverity project name this is uploaded to.
Also apply renaming in file content: call renamed build_Osmocom.sh, use dir
source-Osmocom and install-Osmocom, use a token named 'Osmocom'.
The point is that the combined build of all osmocom projects finds problems
more accurately, since coverity can analyse across all libraries at the same
time.
Still build the iuh branches, since they are basically an extension of the
current master branches (given that they are rebased onto master regularly,
which they currently are).
Name the generated tar Osmocom.tgz instead of myproject.tgz.
Change-Id: If316d54327cca8aa1b499bf35b6b22385bd83702
Vadim Yanitskiy
Oliver Smith
Pau Espin
Neels Hofmeyr
Harald Welte
Neels Hofmeyr