From 2b526e6941799965012163a9ab2c304e0c036b40 Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <neels@hofmeyr.de>
Date: Mon, 26 Mar 2018 19:55:26 +0200
Subject: [PATCH] jobs/master: optimize trigger chain

Avoid as many multiple triggers as still ensure all dependent projects are
rebuilt correctly. Keep the full trigger list as comment, and illustrate in a
comment at libosmocore how the chain is intended to work.

Change-Id: Iea2cf25b3872045778f11a985a1c417f37067cd9
---
 jobs/master-builds.yml | 87 ++++++++++++++++++++++++++++++++++++------
 1 file changed, 75 insertions(+), 12 deletions(-)

diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 029ffa21..79ce8c2b 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -33,15 +33,24 @@
               osmocom:amd64 /build/contrib/jenkins.sh
 
       - libasn1c:
-          trigger: master-osmo-iuh, master-osmo-msc
+          # Full triggers would be:
+          # trigger: master-osmo-iuh, master-osmo-msc
+          # Optimized:
+          # osmo-iuh triggers osmo-msc
+          trigger: master-osmo-iuh
 
       - libgtpnl:
           trigger: master-osmo-ggsn, openggsn
 
       - libosmo-abis:
+          # Full triggers would be:
+          # trigger: >
+          #   master-libosmo-netif, master-osmo-bsc, master-osmo-bts, master-osmo-hlr,
+          #   master-osmo-msc, master-osmo-sgsn, master-openbsc
+          # Optimized:
+          # (see comment at libosmocore)
           trigger: >
-            master-libosmo-netif, master-osmo-bsc, master-osmo-bts, master-osmo-hlr,
-            master-osmo-msc, master-osmo-sgsn, master-openbsc
+            master-libosmo-netif, master-osmo-bts
 
       - libosmo-dsp:
           cmd: >
@@ -53,25 +62,73 @@
           trigger: master-osmo-gmr
 
       - libosmo-netif:
+          # Full triggers would be:
+          # trigger: >
+          #   master-libosmo-sccp, master-openbsc, mastere-osmo-hlr, master-osmo-iuh,
+          #   master-osmo-mgw, master-osmo-msc, master-osmo-sgsn
+          # Optimized:
+          # (see comment at libosmocore)
           trigger: >
-            master-libosmo-sccp, master-openbsc, mastere-osmo-hlr, master-osmo-iuh,
-            master-osmo-mgw, master-osmo-msc, master-osmo-sgsn
+            master-libosmo-sccp,
+            master-osmo-hlr,
+            master-osmo-mgw,
+            master-osmo-sgsn
 
       - libosmo-sccp:
+          # Full triggers would be:
+          # trigger: >
+          #   master-openbsc, master-osmo-bsc, master-osmo-iuh, master-osmo-msc, master-osmo-sgsn
+          # Optimized:
+          # (see comment at libosmocore)
           trigger: >
-            master-openbsc, master-osmo-bsc, master-osmo-iuh, master-osmo-msc, master-osmo-sgsn
+            master-openbsc,
+            master-osmo-bsc,
+            master-osmo-iuh,
+            master-osmo-msc,
+            master-osmo-sgsn
 
       - libosmocore:
           a1_name: arch
           a1: !!python/tuple [arm-none-eabi, amd64]
           combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")'
           cmd: './contrib/jenkins_arch.sh "$arch"'
+          # Full triggers would be:
+          # trigger: >
+          #   master-libosmo-abis, master-libosmo-netif, master-libosmo-sccp, master-openbsc,
+          #   master-osmo-bsc, master-osmo-bts, master-osmo-ggsn, master-osmo-gmr, master-osmo-hlr,
+          #   master-osmo-iuh, master-osmo-mgw, master-osmo-msc, master-osmo-pcap, master-osmo-pcu,
+          #   master-osmo-sgsn, master-osmo-sip-connector, master-osmo-tetra,
+          #   master-osmocom-bb, SIMtrace, xgoldmon
+          # Optimized:
+          # libosmocore
+          # -> master-libosmo-abis
+          #    -> master-libosmo-netif
+          #       -> master-libosmo-sccp
+          #          -> master-openbsc
+          #          -> master-osmo-bsc
+          #          -> master-osmo-iuh
+          #             -> master-osmo-msc
+          #             -> master-osmo-sgsn
+          #          -> master-osmo-msc
+          #          -> master-osmo-sgsn
+          #       -> master-osmo-hlr
+          #       -> master-osmo-mgw
+          #       -> master-osmo-sgsn
+          #    -> master-osmo-bts
+          # -> master-osmo-ggsn
+          #    -> master-osmo-sgsn
+          # [...]
           trigger: >
-            master-libosmo-abis, master-libosmo-netif, master-libosmo-sccp, master-openbsc,
-            master-osmo-bsc, master-osmo-bts, master-osmo-ggsn, master-osmo-gmr, master-osmo-hlr,
-            master-osmo-iuh, master-osmo-mgw, master-osmo-msc, master-osmo-pcap, master-osmo-pcu,
-            master-osmo-sgsn, master-osmo-sip-connector, master-osmo-tetra,
-            master-osmocom-bb, SIMtrace, xgoldmon
+            master-libosmo-abis,
+            master-osmo-ggsn,
+            master-osmo-gmr,
+            master-osmo-pcap,
+            master-osmo-pcu,
+            master-osmo-sip-connector,
+            master-osmo-tetra,
+            master-osmocom-bb,
+            SIMtrace,
+            xgoldmon
 
       - libsmpp34:
           trigger: master-osmo-msc, master-openbsc
@@ -157,7 +214,13 @@
       - osmo-hlr
 
       - osmo-iuh:
-          trigger: master-osmo-msc, master-osmo-sgsn
+          # Full triggers would be:
+          # trigger: master-osmo-msc, master-osmo-sgsn
+          # Optimized:
+          # (see comment at libosmocore)
+          trigger: >
+            master-osmo-msc,
+            master-osmo-sgsn
 
       - osmo-mgw:
           a1_name: MGCP