libosmocore/src
Neels Hofmeyr b54229d2ec osmo_time_cc: rate_ctr presence should not affect counting
Make sure that osmo_time_cc counts exactly the same, regardless of a
rate_ctr being present or not. Only skip sending counter increments when
there is no rate counter, do not affect anything else.

In osmo-bsc, we are discussing a patch where an lchan redirects
osmo_time_cc counter increments to different rate counters depending on
its current type. In my comments I am also claiming that osmo_time_cc
works the same regardless of a rate_ctr being present or not. Looking at
the code, this is not actually the case.

Before this patch, when there is no rate_ctr, the reported_sum would
freeze, and as soon as a rate_ctr shows up, all counter increments from
the previous reported_sum would be sent to the newly set rate_ctr.
Instead, we want counter increments to simply be lost while there is no
rate_ctr set. IOW, rate_ctr == NULL should mean >/dev/null.

Related: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 (osmo-bsc)
Change-Id: I380b28d7ab0a6c8aab6c7e2a64bc73cab14863d2
2022-03-08 23:41:23 +01:00
..
codec treewide: remove FSF address 2021-12-14 12:44:03 +01:00
coding treewide: remove FSF address 2021-12-14 12:44:03 +01:00
ctrl treewide: remove FSF address 2021-12-14 12:44:03 +01:00
gb bssgp_bvc_fsm: Move log message to the correct place 2021-11-19 14:24:41 +01:00
gsm gsm: lapd_core: Change log line NOTICE->INFO 2022-03-02 19:03:32 +01:00
pseudotalloc pseudotalloc: Simplistic wrapper of talloc_named() 2019-07-31 10:16:07 +02:00
sim treewide: remove FSF address 2021-12-14 12:44:03 +01:00
usb usb: Match device by VID/PID without path/addr if it is unique 2022-03-03 17:48:51 +01:00
vty VTY: implement 'no log gsmtap [HOSTNAME]' command 2022-01-05 09:51:34 +00:00
Makefile.am select: gather statistics for TCP connections 2021-12-23 14:52:15 +00:00
application.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
backtrace.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
base64.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
bitcomp.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
bits.c bits.c: Fix -Wsign-compare warnings 2022-01-09 12:04:22 +01:00
bitvec.c bitvec: Fix -Wsign-compare warnings 2022-01-09 12:04:16 +01:00
context.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv.c src/conv.c: Align better with Osmocom coding style 2022-01-05 20:36:34 +00:00
conv_acc.c conv: Fix the traceback for tail biting codes 2022-01-05 20:24:49 +00:00
conv_acc_generic.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_neon.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_neon_impl.h treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse_avx.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse_impl.h treewide: remove FSF address 2021-12-14 12:44:03 +01:00
counter.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
crc16.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
crcXXgen.c.tpl treewide: remove FSF address 2021-12-14 12:44:03 +01:00
exec.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
fsm.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
gsmtap_util.c VTY: implement 'no log gsmtap [HOSTNAME]' command 2022-01-05 09:51:34 +00:00
isdnhdlc.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
it_q.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging.c logging: fix printing of '\0' when filename printed last 2022-01-31 16:56:09 +00:00
logging_gsmtap.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging_syslog.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging_systemd.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
loggingrb.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
macaddr.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
mnl.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
msgb.c msgb: Fix -Wsign-compare warnings 2022-01-10 10:53:06 +01:00
msgfile.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
panic.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
plugin.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
prbs.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
prim.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
probes.d support for stats static userspace probes via systemtap 2021-02-22 09:58:00 +01:00
rate_ctr.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
rbtree.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
select.c socket, select: Fix -Wsign-compare warnings 2022-01-10 10:53:03 +01:00
sercomm.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
serial.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
signal.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
sockaddr_str.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
socket.c add osmo_sockaddr_set_port() 2022-03-01 16:33:40 +00:00
stat_item.c stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free 2021-12-15 11:13:24 +01:00
stat_item_internal.h refactor stat_item: get rid of FIFO and "skipped" error 2021-09-30 18:33:43 +00:00
stats.c select: gather statistics for TCP connections 2021-12-23 14:52:15 +00:00
stats_statsd.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
stats_tcp.c stats: use tcp stat names as provided 2022-02-24 06:22:55 -08:00
strrb.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
tdef.c tdef: fix wrong path in documentation: tests/vty -> tests/tdef 2021-11-17 20:17:59 +00:00
thread.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
time_cc.c osmo_time_cc: rate_ctr presence should not affect counting 2022-03-08 23:41:23 +01:00
timer.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
timer_clockgettime.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
timer_gettimeofday.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
use_count.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
utils.c add osmo_quote_str_buf3, osmo_escape_str_buf3 2022-02-07 22:10:29 +01:00
write_queue.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00