Common library for all Osmocom projects (libosmocore, libosmogsm, libosmovty, libosmogb, libosmosim, libosmousb, ...) https://osmocom.org/projects/libosmocore
Go to file
Neels Hofmeyr b54229d2ec osmo_time_cc: rate_ctr presence should not affect counting
Make sure that osmo_time_cc counts exactly the same, regardless of a
rate_ctr being present or not. Only skip sending counter increments when
there is no rate counter, do not affect anything else.

In osmo-bsc, we are discussing a patch where an lchan redirects
osmo_time_cc counter increments to different rate counters depending on
its current type. In my comments I am also claiming that osmo_time_cc
works the same regardless of a rate_ctr being present or not. Looking at
the code, this is not actually the case.

Before this patch, when there is no rate_ctr, the reported_sum would
freeze, and as soon as a rate_ctr shows up, all counter increments from
the previous reported_sum would be sent to the newly set rate_ctr.
Instead, we want counter increments to simply be lost while there is no
rate_ctr set. IOW, rate_ctr == NULL should mean >/dev/null.

Related: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 (osmo-bsc)
Change-Id: I380b28d7ab0a6c8aab6c7e2a64bc73cab14863d2
2022-03-08 23:41:23 +01:00
contrib contrib/libosmocore.spec.in: mention osmo-config-merge in utils 2022-01-10 14:40:19 +00:00
debian debian/control: minimum version of libtalloc-dev must be >= 2.1.0 2021-11-17 20:13:36 +00:00
doc merge_doc.xsl: move to osmo-gsm-manuals.git 2018-11-12 14:07:05 +01:00
include add osmo_sockaddr_set_port() 2022-03-01 16:33:40 +00:00
m4 Add code coverage support 2019-11-30 02:17:23 +00:00
src osmo_time_cc: rate_ctr presence should not affect counting 2022-03-08 23:41:23 +01:00
tapset support for stats static userspace probes via systemtap 2021-02-22 09:58:00 +01:00
tests gsm: [ABI BREAK] Support CellId SAI, change CellId CGI-PS id number 2022-02-16 17:59:23 +01:00
utils treewide: remove FSF address 2021-12-14 12:44:03 +01:00
.gitignore .gitignore: add utils/osmo-aka-verify binary 2021-11-17 01:54:16 +03:00
.gitreview add .gitreview 2016-05-19 06:39:13 +00:00
.mailmap Add .mailmap file for mapping mail addresses in shortlog 2016-08-08 13:12:17 +02:00
COPYING add GPL to project source 2010-02-21 09:21:30 +01:00
Doxyfile.codec.in Set HTML_TIMESTAMP to NO to make build reproducible 2019-07-17 11:03:44 +00:00
Doxyfile.coding.in doxygen: enable cross referencing everywhere 2019-02-04 16:43:57 +00:00
Doxyfile.core.in Set HTML_TIMESTAMP to NO to make build reproducible 2019-07-17 11:03:44 +00:00
Doxyfile.ctrl.in doxygen: enable cross referencing everywhere 2019-02-04 16:43:57 +00:00
Doxyfile.gb.in doxygen: enable cross referencing everywhere 2019-02-04 16:43:57 +00:00
Doxyfile.gsm.in Set HTML_TIMESTAMP to NO to make build reproducible 2019-07-17 11:03:44 +00:00
Doxyfile.vty.in Set HTML_TIMESTAMP to NO to make build reproducible 2019-07-17 11:03:44 +00:00
Makefile.am initial support for static userspace probes via systemtap 2021-02-03 13:55:40 +00:00
README.md README.md: Use https everywhere 2021-02-11 11:57:13 +01:00
TODO-RELEASE BSSAP: HO Request Ack: add missing Codec List (BSS Supported) 2022-02-28 11:04:08 +00:00
configure.ac tcp_stats: fix compilation on CentOS 7 2021-12-24 11:34:18 +01:00
git-version-gen add git-version-gen magic to automatically generate package version 2010-03-23 00:30:19 +08:00
libosmocodec.pc.in pkgconfig/osmocodec/osmocoding: link to talloc 2020-07-20 23:52:31 +02:00
libosmocoding.pc.in pkgconfig/osmocodec/osmocoding: link to talloc 2020-07-20 23:52:31 +02:00
libosmocore.pc.in libosmocore.pc.in: Append -lsctp to Libs.private 2019-10-22 16:09:05 +02:00
libosmoctrl.pc.in remove our internal copy of talloc, use system libtalloc 2015-12-05 23:38:18 +01:00
libosmogb.pc.in Revert "pkgconfig: link to mnl if available" 2021-01-08 10:14:02 +00:00
libosmogsm.pc.in remove our internal copy of talloc, use system libtalloc 2015-12-05 23:38:18 +01:00
libosmosim.pc.in remove our internal copy of talloc, use system libtalloc 2015-12-05 23:38:18 +01:00
libosmousb.pc.in libosmocore libusb integration 2019-12-16 00:17:27 +01:00
libosmovty.pc.in remove our internal copy of talloc, use system libtalloc 2015-12-05 23:38:18 +01:00
osmo-release.mk Fixup severe build performance issues 2017-10-04 16:26:37 +02:00
osmo-release.sh osmo-release.sh: Use variable containing bumpversion path everywhere 2022-01-05 23:09:17 +00:00

README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone git://git.osmocom.org/libosmocore.git

There is a cgit interface at https://git.osmocom.org/libosmocore/

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open