libosmocore/e2ac1a1b4c0f2b2674bf69a1ef0...

279 lines
7.8 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bc4c4b5c_e36373ae",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Updated static helper instead of creating new function as requested in feedback.",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d53f555c_f92e43e0",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 206,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "There is no \u0027buf_len\u0027 anymore. And it looks like this comment was initially incorrect: it should be host_count/addrs_count I guess?",
"range": {
"startLine": 206,
"startChar": 3,
"endLine": 206,
"endChar": 10
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "4f88114f_3d679a33",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 206,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "d53f555c_f92e43e0",
"range": {
"startLine": 206,
"startChar": 3,
"endLine": 206,
"endChar": 10
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "929275f4_7dc7d54a",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 211,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "cosmetic: alignment needs to be fixed here",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "1bbaa60a_5f2764e9",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 211,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "929275f4_7dc7d54a",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e19adda9_0983c84b",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 220,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the same time.",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "cabdfc50_85dde7a2",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 220,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Seems rather pointless to me: that\u0027s a static function with only few invocations, not part of public API so we don\u0027t have to insure against user who failed to read the docs.",
"parentUuid": "e19adda9_0983c84b",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1504e0df_a1cc8835",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 236,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "Before your patch this function would print \"0.0.0.0\" if hosts[i] is NULL.\nYou\u0027re changing it to not print anything. What\u0027s your motivation?",
"range": {
"startLine": 236,
"startChar": 3,
"endLine": 236,
"endChar": 16
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ee49f2e0_1692bab0",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 236,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "That seems like odd side-effect to me for which I couldn\u0027t find any tests. Having NULL input we can\u0027t guess whether IPv4 or IPv6 address to show. Moreover, print helper seems like a wrong place for such guesswork in a first place - the caller have more context information and can pass proper default explicitly. I\u0027ll update commit message to make it more visible.",
"parentUuid": "1504e0df_a1cc8835",
"range": {
"startLine": 236,
"startChar": 3,
"endLine": 236,
"endChar": 16
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "eb09c2cb_42c8e947",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 241,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "LOGL_ERROR? Not sure if we need to log anything here though.",
"range": {
"startLine": 241,
"startChar": 19,
"endLine": 241,
"endChar": 29
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "610e45fc_467ccb3f",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 241,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "eb09c2cb_42c8e947",
"range": {
"startLine": 241,
"startChar": 19,
"endLine": 241,
"endChar": 29
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "eeab4d3a_6d3e68f1",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 749,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "Better do sizeof(strbuf).",
"range": {
"startLine": 749,
"startChar": 49,
"endLine": 749,
"endChar": 52
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "4c36e3d1_1f51e592",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 749,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "eeab4d3a_6d3e68f1",
"range": {
"startLine": 749,
"startChar": 49,
"endLine": 749,
"endChar": 52
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}