libosmocore/src
Michael Iedema a6d1ef0d60 stats: use tcp stat names as provided
If an API user has defined a name for this particular
stat, we should consider it unique and not append ip and
port information from the connection.

By appending ip and port information to all tcp stat
names, we end up creating unique stat names every
time a reconnection occurs and the source port changes.
This makes the statistic impossible to track over time
as it is continually using a different name.

A quick example from the field over the course of a
day:

tcp.ipa-rsl-0,r=192.168.55.88.33056<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.33311<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.35510<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.35958<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.36110<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.39269<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.40394<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.40397<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.42920<->l=192.168.0.1.3003.tcp.rtt
tcp.ipa-rsl-0,r=192.168.55.88.43839<->l=192.168.0.1.3003.tcp.rtt

This change would treat tcp stats like other stats
around the system. A unique name must be set by the
API user. This would let us set a unique name like
the following to avoid the situation above:

bts.0.rsl.0.tcp.rtt

Matching the existing rsl related stats:

bts.0.rsl.delete_ind
bts.0.rsl.ipa_nack
bts.0.rsl.unknown

...they retain a constant name regardless of the underlying
connectivity situation.

Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2
2022-02-24 06:22:55 -08:00
..
codec treewide: remove FSF address 2021-12-14 12:44:03 +01:00
coding treewide: remove FSF address 2021-12-14 12:44:03 +01:00
ctrl treewide: remove FSF address 2021-12-14 12:44:03 +01:00
gb bssgp_bvc_fsm: Move log message to the correct place 2021-11-19 14:24:41 +01:00
gsm gsm: [ABI BREAK] Support CellId SAI, change CellId CGI-PS id number 2022-02-16 17:59:23 +01:00
pseudotalloc pseudotalloc: Simplistic wrapper of talloc_named() 2019-07-31 10:16:07 +02:00
sim treewide: remove FSF address 2021-12-14 12:44:03 +01:00
usb osmo_libusb: Print log message on libusb initialization error 2022-01-31 18:40:03 +01:00
vty VTY: implement 'no log gsmtap [HOSTNAME]' command 2022-01-05 09:51:34 +00:00
Makefile.am select: gather statistics for TCP connections 2021-12-23 14:52:15 +00:00
application.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
backtrace.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
base64.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
bitcomp.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
bits.c bits.c: Fix -Wsign-compare warnings 2022-01-09 12:04:22 +01:00
bitvec.c bitvec: Fix -Wsign-compare warnings 2022-01-09 12:04:16 +01:00
context.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv.c src/conv.c: Align better with Osmocom coding style 2022-01-05 20:36:34 +00:00
conv_acc.c conv: Fix the traceback for tail biting codes 2022-01-05 20:24:49 +00:00
conv_acc_generic.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_neon.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_neon_impl.h treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse_avx.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
conv_acc_sse_impl.h treewide: remove FSF address 2021-12-14 12:44:03 +01:00
counter.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
crc16.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
crcXXgen.c.tpl treewide: remove FSF address 2021-12-14 12:44:03 +01:00
exec.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
fsm.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
gsmtap_util.c VTY: implement 'no log gsmtap [HOSTNAME]' command 2022-01-05 09:51:34 +00:00
isdnhdlc.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
it_q.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging.c logging: fix printing of '\0' when filename printed last 2022-01-31 16:56:09 +00:00
logging_gsmtap.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging_syslog.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
logging_systemd.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
loggingrb.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
macaddr.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
mnl.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
msgb.c msgb: Fix -Wsign-compare warnings 2022-01-10 10:53:06 +01:00
msgfile.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
panic.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
plugin.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
prbs.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
prim.c Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
probes.d support for stats static userspace probes via systemtap 2021-02-22 09:58:00 +01:00
rate_ctr.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
rbtree.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
select.c socket, select: Fix -Wsign-compare warnings 2022-01-10 10:53:03 +01:00
sercomm.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
serial.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
signal.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
sockaddr_str.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
socket.c follow-up to osmo_sockaddr_from/to_octets() 2022-02-07 22:15:27 +01:00
stat_item.c stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free 2021-12-15 11:13:24 +01:00
stat_item_internal.h refactor stat_item: get rid of FIFO and "skipped" error 2021-09-30 18:33:43 +00:00
stats.c select: gather statistics for TCP connections 2021-12-23 14:52:15 +00:00
stats_statsd.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
stats_tcp.c stats: use tcp stat names as provided 2022-02-24 06:22:55 -08:00
strrb.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
tdef.c tdef: fix wrong path in documentation: tests/vty -> tests/tdef 2021-11-17 20:17:59 +00:00
thread.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
time_cc.c add osmo_time_cc, moved from osmo-bsc 2021-11-15 09:06:03 +00:00
timer.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
timer_clockgettime.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
timer_gettimeofday.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
use_count.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00
utils.c add osmo_quote_str_buf3, osmo_escape_str_buf3 2022-02-07 22:10:29 +01:00
write_queue.c treewide: remove FSF address 2021-12-14 12:44:03 +01:00