mirror of https://gerrit.osmocom.org/libosmocore
21 lines
727 B
Plaintext
21 lines
727 B
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9bd70bec_97f7ccdc",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-12T11:45:11Z",
|
|
"side": 1,
|
|
"message": "I\u0027m sorry but I see more drawbacks than benefits here. Heap allocation + converting a string addr to a sockaddr and back to a string. Amount of lines still more or less the same. This doesn\u0027t look good to me. If others like this then they will provide enough votes.",
|
|
"revId": "c9206aaa19bafd2d4d68d2575ba7bc284524a95d",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |