Common library for all Osmocom projects (libosmocore, libosmogsm, libosmovty, libosmogb, libosmosim, libosmousb, ...) https://osmocom.org/projects/libosmocore
Go to file
Sylvain Munaut 71fd42fede gsm/gsm48_ie: Fix Range 256 format decoding
From the mail:

---
appended is another patch for fixing a bug in the calculation of the
frequency lists. This time the patch is for the "Range 256 format".
The problem is that the operand for the "smod" operation might be
negative, in this case the simplified version won't work as expected.

In the patch I introduced a separate function for "smod" which takes
care of the sign. I have not yet checked if the other formats are also
affected, this would be the case if the "smod" operand can be negative.

There might be other solutions to fix the problem without the need
for a separate function, however I have not thought further about it.

A test vector is the following frequency list ("Range 256 format",
first byte is the length):

 09 8b 1c 83 8c 15 ef 02 2d 30

The correct ARFCNs are

 569 571 576 578 586 608 712 715 719

The uncorrected version would instead return:

 444 457 460 464 569 576 578 586 608

This means four ARFCNs are wrong which will cause problems if for
example the frequency list contains the ARFCNs for hopping.
----

Written-by: Dieter Spaar <spaar@mirider.augusta.de>
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2011-09-01 22:05:29 +02:00
debian Revert various debian related changes 2011-07-16 11:11:31 +02:00
doc Integrate doxygen documentation building into autoconf/automake process 2011-08-17 19:33:06 +02:00
include logging: include stdarg.h for va_list 2011-09-01 17:44:35 +02:00
m4 Create a dummy m4 directory to make autoreconf --install --force work 2010-03-24 02:55:33 +01:00
src gsm/gsm48_ie: Fix Range 256 format decoding 2011-09-01 22:05:29 +02:00
tests add functions for bit-reversal 2011-09-01 14:47:31 +02:00
utils add script to generate http://www.osmocom.org/doc tree structure 2011-08-20 17:40:08 +02:00
.gitignore update .gitignore with Doxyfile.core 2011-08-20 17:40:13 +02:00
COPYING add GPL to project source 2010-02-21 09:21:30 +01:00
Doxyfile.codec.in Auto-generate the version information of Doxygen documentation 2011-08-17 19:22:12 +02:00
Doxyfile.core.in consistent Doxyfile naming 2011-08-20 17:39:58 +02:00
Doxyfile.gsm.in Auto-generate the version information of Doxygen documentation 2011-08-17 19:22:12 +02:00
Doxyfile.vty.in Auto-generate the version information of Doxygen documentation 2011-08-17 19:22:12 +02:00
Makefile.am Make sure 'make distclean' works for doxygen 2011-08-20 17:40:04 +02:00
configure.ac add functions for bit-reversal 2011-09-01 14:47:31 +02:00
git-version-gen add git-version-gen magic to automatically generate package version 2010-03-23 00:30:19 +08:00
libosmocodec.pc.in codec: Add the missing bits for include to install and pkgconfig to work 2010-10-24 18:23:10 +02:00
libosmocore.pc.in add missing automake / autoconf files 2010-02-20 21:09:24 +01:00
libosmogsm.pc.in This patch moves the GSM-specific functions to the new library 2011-03-23 18:08:08 +01:00
libosmovty.pc.in Add pkgconfig for libosmovty 2010-05-25 22:28:40 +02:00