osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity
libosmocore/src
History
Neels Hofmeyr 74aa025826 Revert "vty: Fix bad use of vector_slot()" 
The patch seemed sensible, but introduces a segfault when hitting tab
on the interactive VTY. Reproduction example:

  osmo-msc
  telnet 127.0.0.1 4254
  OsmoMSC> enable <TAB>

So we need to understand what that line of code actually intends to do.
Until then, revert this to avoid the segfault.

The segfault happens at:

  Program received signal SIGSEGV, Segmentation fault.
  0x00007ffff7bc0894 in cmd_complete_command_real (vline=0x5555558d59e0, vty=0x5555558d57b0, status=0x7fffffffe024) at ../../../../src/libosmocore/src/vty/command.c:1953
  1953                if (*(char *)vector_slot(vline, index) == '\0')

This reverts commit e9e9e427b7.

Change-Id: I3fe213bdfb96de9469aae64e67000dafee59302e
 		2017-11-01 22:38:29 +00:00
..
codec doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
coding Makefile.am: fix missing LTLDFLAGS for libosmocoding 2017-08-31 17:53:04 +07:00
ctrl Move additional libraries to appropriate place 2017-10-30 13:50:31 +01:00
gb Move additional libraries to appropriate place 2017-10-30 13:50:31 +01:00
gsm Move additional libraries to appropriate place 2017-10-30 13:50:31 +01:00
pseudotalloc doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
sim Move additional libraries to appropriate place 2017-10-30 13:50:31 +01:00
vty Revert "vty: Fix bad use of vector_slot()" 2017-11-01 22:38:29 +00:00
Makefile.am Move additional libraries to appropriate place 2017-10-30 13:50:31 +01:00
application.c Catch repeated calls to osmo_init_logging() 2017-10-29 09:45:21 +00:00
backtrace.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
bitcomp.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
bits.c [doc] bits.c: Better / more Doxygen documentation 2017-10-16 14:19:12 +02:00
bitvec.c Simplify bitvec_write_field() 2017-10-24 12:08:34 +02:00
conv.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
conv_acc.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
conv_acc_generic.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
conv_acc_sse.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
conv_acc_sse_avx.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
conv_acc_sse_impl.h Ensure __always_inline is defined on operating systems that don't have it 2017-10-09 11:00:56 +08:00
counter.c [doc] counter.[ch] Add Doxygen API documentation 2017-10-16 14:18:54 +02:00
crc16.c [doc] Put CRC-16 and generic CRC code in one Doxygen module 2017-10-16 14:29:26 +02:00
crcXXgen.c.tpl [doc] Put CRC-16 and generic CRC code in one Doxygen module 2017-10-16 14:29:26 +02:00
fsm.c fsm: Enforce FSM and FSM instance names are valid osmocom identifiers 2017-10-24 16:00:45 +00:00
gsmtap_util.c chantype_rsl2gsmtap/gsmtap2rsl: Fix PDCH channel type conversion 2017-07-28 21:26:10 +00:00
logging.c [doc] src/logging.c: Fix Doxygen syntax to make logging.c show up in logging group 2017-10-16 14:19:00 +02:00
logging_gsmtap.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
logging_syslog.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
loggingrb.c [doc] Introductory text on what the logging ring buffer is about 2017-10-16 14:37:31 +02:00
macaddr.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
msgb.c add function msgb_printf() to print formatted text into msg buf 2017-10-22 20:09:26 +00:00
msgfile.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
panic.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
plugin.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
prbs.c Add pseudo-random bit sequence generator to libosmcoore 2017-07-10 23:42:02 +02:00
prim.c [doc] Expand Doxuygen documentation for osmo_prim 2017-10-16 14:52:37 +02:00
rate_ctr.c rate_ctr: Fix null pointer dereference in error path 2017-10-24 16:46:33 +00:00
rbtree.c fix FSF address in sources/headers 2015-11-12 13:46:05 +01:00
select.c add osmo_fd_setup() convenience function to fill-in osmo_fd 2017-08-12 11:43:14 +02:00
sercomm.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
serial.c serial.c: Use pragma message instead of warning 2017-06-23 11:06:37 +02:00
signal.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
socket.c socket: add function osmo_sock_local_ip() to query local ip 2017-10-23 08:47:38 +00:00
stat_item.c [doc] stat_item: Complete doxygen documentation for API 2017-10-16 14:18:50 +02:00
stats.c [doc] Add Doxygen API documentation for stats.c and stats_statsd.c 2017-10-16 14:18:56 +02:00
stats_statsd.c [doc] Add Doxygen API documentation for stats.c and stats_statsd.c 2017-10-16 14:18:56 +02:00
strrb.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
timer.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00
timer_gettimeofday.c Expand osmo_gettimeofday() docs 2017-10-23 17:53:11 +00:00
utils.c osmo_char2bcd(): Implment hex digits a-f and A-F 2017-10-27 16:55:16 +02:00
write_queue.c doxygen: unify use of \file across the board 2017-06-23 00:18:23 +00:00