Harald Welte 7869baf843 Deprecate ipa_ccm_idtag_parse() with ipa_ccm_id_{get,resp}_parse() ... In the past, the function ipa_ccm_idtag_parse() was used to parse the payload of IPA CCM ID RESP packets. However, the function was based on a possible misunderstanding of the message encoding, and callers actually counted the first (upper) length nibble as part of the header and passed a pointer to the second (lower) length nibble of the first TLV into this function. As such, it was unfixable, and had to be replaced with a new function called ipa_ccm_id_resp_parse(). At the same time, we also add ipa_ccm_id_get_parse() to parse the slightly different format of the IPA CCM ID GET payload. We can never be 100% sure what is "correct", as our understanding of the protocol is entirely based on protocol analysis, without any official documentation available. This patch also introduces unit test coverage for both of the new functions. Revert "ipa: Add libosmogsm.map entry for ipa_ccm_idtag_parse_off" This reverts commit 7f31c90b80. Revert "ipa: Properly parse LV stream of a ID_GET request" This reverts commit f558ed4bb9. It introduced a function/behavior that was not originally intended: The parse of IPA CCM ID GET (8bit length followed by 1 byte tag and variable-length payload) instead of the IPA CCM ID RESP (16bit length followed by 1 byte tag and variable-length payload). Change-Id: I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f		2018-08-01 13:38:17 +02:00
..
utils_test.c	Deprecate ipa_ccm_idtag_parse() with ipa_ccm_id_{get,resp}_parse()	2018-08-01 13:38:17 +02:00
utils_test.err	utils_test: check stderr to catch sanitizer issues	2018-07-20 14:02:21 +00:00
utils_test.ok	Deprecate ipa_ccm_idtag_parse() with ipa_ccm_id_{get,resp}_parse()	2018-08-01 13:38:17 +02:00