{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "dd93c751_9be04fe6",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 8
      },
      "lineNbr": 0,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2022-08-17T00:48:15Z",
      "side": 1,
      "message": "the code added in https://gerrit.osmocom.org/c/libosmocore/+/28992 should move to this function, as indicated below",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "fd1a1b1e_615cd34b",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 8
      },
      "lineNbr": 0,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-09-29T05:39:59Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "dd93c751_9be04fe6",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "dda0b532_5a697daa",
        "filename": "src/socket.c",
        "patchSetId": 8
      },
      "lineNbr": 208,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2022-08-17T00:48:15Z",
      "side": 1,
      "message": "(this doc is wrong)",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b561a406_fc5010a7",
        "filename": "src/socket.c",
        "patchSetId": 8
      },
      "lineNbr": 208,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-09-29T05:39:59Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "dda0b532_5a697daa",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "16eeb34d_42c05fa7",
        "filename": "src/socket.c",
        "patchSetId": 8
      },
      "lineNbr": 211,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2022-08-17T00:48:15Z",
      "side": 1,
      "message": "if you use an implementation like this here, we don\u0027t need to add osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations:\n\n\n  struct osmo_strbuf sb \u003d { ... };\n  if (i !\u003d 1)\n      OSMO_STRBUF_PRINTF(sb, \"(\");\n  for (...) {\n      struct osmo_sockaddr_str ss;\n      if (i)\n         OSMO_STRBUF_PRINTF(sb, \"|\");\n      osmo_sockaddr_str_from_str2(\u0026ss, hosts[i]);\n      OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT, OSMO_SOCKADDR_STR_FMT_ARGS(\u0026ss));\n   }\n  if (i !\u003d 1)\n      OSMO_STRBUF_PRINTF(sb, \")\");\n  return sb.chars_needed;",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b064f7de_37eaf3a4",
        "filename": "src/socket.c",
        "patchSetId": 8
      },
      "lineNbr": 211,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-09-29T05:39:59Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "16eeb34d_42c05fa7",
      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}