{ "comments": [ { "unresolved": false, "key": { "uuid": "f0224e4c_231aaeff", "filename": "/PATCHSET_LEVEL", "patchSetId": 6 }, "lineNbr": 0, "author": { "id": 1000074 }, "writtenOn": "2022-08-10T13:54:03Z", "side": 1, "message": "What do we win with this? I see only drawbacks: allocating and freeing N more buffers on the heap everytime it is called.", "revId": "df43910c8f6b3edfeb985f391b15632e04a75a41", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "b6fc0b29_1b59f0eb", "filename": "/PATCHSET_LEVEL", "patchSetId": 6 }, "lineNbr": 0, "author": { "id": 1000159 }, "writtenOn": "2022-08-12T10:57:59Z", "side": 1, "message": "We gain decrease of code duplication - we use the same function which is also used in other place in the follow-up patches. I don\u0027t think heap alloc matter - that code is called only at the socket init and the number of sockets is a limited resource so it\u0027s very unlikely to ever end up on a hot codepath.", "parentUuid": "f0224e4c_231aaeff", "revId": "df43910c8f6b3edfeb985f391b15632e04a75a41", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "14293a14_3c048ce5", "filename": "/PATCHSET_LEVEL", "patchSetId": 6 }, "lineNbr": 0, "author": { "id": 1000159 }, "writtenOn": "2022-09-29T05:39:59Z", "side": 1, "message": "Done", "parentUuid": "b6fc0b29_1b59f0eb", "revId": "df43910c8f6b3edfeb985f391b15632e04a75a41", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] }