libosmocore

Commit Graph

Author	SHA1	Message	Date
Holger Hans Peter Freyther	f558ed4bb9	ipa: Properly parse LV stream of a ID_GET request For some reason the structure is closer to be a LV (length and value). The value is actually a tag but it is counted inside the length. Introduce an overload of the parse function to provide an offset for the length. This will be taken from the returned length.	2015-06-02 15:52:06 +02:00
Nils O. Selåsdal	3244702058	utils: Greatly improve performance of osmo_hexdump routines In the osmo-bts and libosmo-abis code the hexdump routine is used for every incoming/outgoing packet (including voice frames) and the usage of snprintf showed up inside profiles. There is a semantic change when more than 4096 characters are used. The code will now truncate at byte boundaries (and not nibbles). Code: static const int lengths[] = { 23, 1000, 52 }; char buf[4096]; int i; for (i = 0; i < 30000; ++i) char *res = osmo_hexdump(buf, lengths[i & 3]); Results: before: after: real 0m3.233s real 0m0.085s user 0m3.212s user 0m0.084s sys 0m0.000s sys 0m0.000s	2014-01-02 14:08:11 +01:00
Holger Hans Peter Freyther	b79a148eca	utils: Add a simple testcase for osmo_hexdump This code makes a simple dump and tests for the corner case	2014-01-02 13:59:10 +01:00

Author

SHA1

Message

Date

Holger Hans Peter Freyther

f558ed4bb9

ipa: Properly parse LV stream of a ID_GET request

For some reason the structure is closer to be a LV (length
and value). The value is actually a tag but it is counted
inside the length. Introduce an overload of the parse function
to provide an offset for the length. This will be taken from
the returned length.

2015-06-02 15:52:06 +02:00

Nils O. Selåsdal

3244702058

utils: Greatly improve performance of osmo_hexdump routines

In the osmo-bts and libosmo-abis code the hexdump routine is used
for every incoming/outgoing packet (including voice frames) and the
usage of snprintf showed up inside profiles.

There is a semantic change when more than 4096 characters are used.
The code will now truncate at byte boundaries (and not nibbles).

Code:
 static const int lengths[] = { 23, 1000, 52 };
 char buf[4096];
 int i;

 for (i = 0; i < 30000; ++i)
     char *res = osmo_hexdump(buf, lengths[i & 3]);

Results:

before:					after:
real    0m3.233s			real    0m0.085s
user    0m3.212s			user    0m0.084s
sys     0m0.000s			sys     0m0.000s

2014-01-02 14:08:11 +01:00

Holger Hans Peter Freyther

b79a148eca

utils: Add a simple testcase for osmo_hexdump

This code makes a simple dump and tests for the corner case

2014-01-02 13:59:10 +01:00

3 Commits