Andreas Eversberg
f44ed8cf92
Fix: Correcting bssgp_tx_fc_bvc, bssgp_tx_fc_ms, bssgp_tx_ul_ud
2012-09-30 14:38:20 +02:00
Andreas Eversberg
aaccdac55d
Fix: gprs_ns_destroy() now frees all NSVCs and its timers
...
Freeing memory of registered timers and file descriptors cause corrupt
lists.
2012-09-29 20:36:31 +02:00
Holger Hans Peter Freyther
779d2f42a4
logging: Modify the testcase to excercise Nico's fix
2012-09-27 16:31:29 +02:00
Holger Hans Peter Freyther
4b54cab476
logging: Move the logging test from OpenBSC into libosmocore
...
Add a testcase for the logging facility. The test is coming from
the OpenBSC code.
2012-09-27 16:29:54 +02:00
Nico Golde
0262d3ff9f
logging.c: Do not crash on empty category name
...
log_parse_category_mask(), skip log category name right away if
name is NULL to prevent passing a NULL ptr to strlen.
2012-09-27 13:45:03 +02:00
Nico Golde
5b67a04a34
gsm_utils.c: in 7bit decoding, first check if the last character was an extension character before doing anything else
2012-09-21 09:25:08 +02:00
Harald Welte
be55a8b814
gsm_utils: Fix up coding style in previous patch
...
'if' is not a function, so we have space before parenthesis.
2012-09-20 10:00:25 +02:00
Nico Golde
bb67be9bd2
build: fix directory creation for core headers, introduced by d471a219
.
2012-09-20 09:58:45 +02:00
Nico Golde
c56a56dc0a
gsm_utils.c: cleanup + do not use dynamic memory when decoding 7bit messages
2012-09-20 09:58:39 +02:00
Max
db75331e06
Fix build with dpkg-buildpackage.
2012-09-17 08:36:46 +02:00
Holger Hans Peter Freyther
eacba189b1
git: Ignore generated tests executables
2012-09-11 12:28:09 +02:00
Holger Hans Peter Freyther
7c7d39adac
vty: Include osmocom/core/utils.h for the value_string struct
2012-09-11 12:27:03 +02:00
Holger Hans Peter Freyther
c302eca2c6
tests: Make the gb test work with srcdir != builddir
...
* Disable color and printing the filename of the stderr log target,
update the results
* Add the .ok, .err and .sh files to the extra_dist
* Execute the shell script from the source directory
2012-09-11 11:49:35 +02:00
Holger Hans Peter Freyther
db1533651f
logging: Introduce a print_filename flag for the logtarget
...
Introduce a print_filename attribute for each logtarget. Initialize it
with 1 to be backward compatible with earlier versions. The bit is taken
from an existint bitfield. There were at least six bits left of the byte.
2012-09-11 11:24:51 +02:00
Holger Hans Peter Freyther
314c010733
vty: Address compiler warning about the const qualifier
...
vty.c: In function 'vty_out_newline':
vty.c:294:12: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
2012-09-11 10:40:07 +02:00
Holger Hans Peter Freyther
b321b93286
vty: Address compiler warning about tolower
...
Include ctype.h to have a declaration of tolower.
utils.c: In function 'vty_cmd_string_from_valstr':
utils.c:95:6: warning: implicit declaration of function 'tolower' [-Wimplicit-function-declaration]
2012-09-11 10:39:29 +02:00
Holger Hans Peter Freyther
cc7d9ec20e
gsm: Address compiler warning about unused variable 'z'
...
The comment explains why we don't care about the content of z,
stop storing it.
gsm_utils.c: In function 'gsm_7bit_encode':
gsm_utils.c:253:13: warning: variable 'z' set but not used [-Wunused-but-set-variable]
2012-09-11 10:38:43 +02:00
Holger Hans Peter Freyther
06f645542c
logging: Mark the log_info_cat pointer as consts
...
Applications should keep the log area in a static const area. Mark
the pointer as const to address compiler warnings in OpenBSC, cast
the const away for the osmo_log_info as it is not declared as const.
2012-09-11 10:31:29 +02:00
Harald Welte
e92866bbb1
Gb: Add functions for sending flow control messages from BSS side
2012-09-10 08:56:04 +02:00
Harald Welte
30fabdf61d
Gb: Add header file for BSS-side BSSGP functions
...
.. not sure how we could have missed that so far.
2012-09-10 08:54:35 +02:00
Harald Welte
e3a10b66a4
libosmogb: make build conditional, disable in embedded build
...
when we build for osmocom-bb cross-compilation, we don't have
sockets nor netinet/in.h and thus NS/BSSGP make no sense...
2012-09-08 22:18:43 +02:00
Harald Welte
aef917593a
backtrace: don't use fprintf, but printf (for osmocom-bb)
2012-09-08 22:00:13 +02:00
Harald Welte
972b502eca
msgb: msgb_get() is supposed to get bytes from END, msgb_pull() from HEAD
...
msgb_get() has been wrong all the time, despite the documentation being
correct. If you've used the broken msgb_get() before, you have to
change your code now, sorry.
2012-09-08 20:01:00 +02:00
Harald Welte
b1789b044a
Merge branch 'bssgp_fc'
2012-09-07 12:14:07 +02:00
Harald Welte
0823e1e42a
BSSGP: print per-bvc flow control parameters on vty
2012-09-07 12:13:09 +02:00
Harald Welte
d8b476988d
BSSGP: make bvc_ctx->fc a dynamic talloc allocation
...
this ensures that we can talloc the flow-control queue entries
as siblings off the bvc_ctx.
2012-09-07 12:07:54 +02:00
Harald Welte
04f0989d11
GPRS BSSGP test: integrate into autotest
...
we use a smalle shell script to iterate over multiple tests
2012-09-07 12:07:54 +02:00
Harald Welte
57e5b94e90
BSSGP flow-control: Add unit test for algorithm tests
2012-09-07 12:07:54 +02:00
Harald Welte
bb8262275f
BSSGP flow-control: various fixes
...
* add more comments on units of struct members
* make sure to parsre FC-BVC message correctly
* add error message in case user passes PDU larger than bucket size
* add new function to initialize flow control struct
2012-09-07 12:07:54 +02:00
Harald Welte
d11c059502
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch
...
This code is supposed to implement the BSSGP flow control algorithm,
both for the per-BSS and for the per-MS flow control.
The code currently has no test cases, they will come in a separate
commit.
2012-09-07 12:07:54 +02:00
Harald Welte
1f87d75b7a
USSD: text is 'char' not uint8_t
2012-09-07 12:07:10 +02:00
Harald Welte
5b3bffb74c
BSSGP: fix unused variable compiler warnings
2012-09-07 12:03:40 +02:00
Harald Welte
ca0af8a3a8
libosmogb: build without strict aliasing rules
...
This allows us to reliably do the trick with casting structures like
libgb_msgb_cb to the msgb->cb[] array. Shamelessly stolen from the
Linux kernel.
2012-09-07 12:01:28 +02:00
Harald Welte
a102b63c28
gsmtap: add minimal support for encapsulating UMTS RRC in GSMTAP
2012-09-02 14:07:57 +02:00
Harald Welte
7c8e2cc7ac
libosmogsm: Back-port SMS related fixes from openbsc
...
This was fixed in 9c3dc90d16a40789081c84e46620f4d66689fec1 of
openbsc.git, after the sms code had been migrated here:
introduce HAVE_TM_GMTOFF_IN_TM
Not all architectures have the tm.tm_gmtoff member. This fixes cygwin builds.
2012-08-29 16:47:30 +02:00
Eric Butler
b5372ab110
Use package version since git info won't be available.
2012-08-26 20:11:24 +02:00
Eric Butler
8dbdc4f3d4
Fix debian package building.
...
* Removed log file
* Add 'git' add 'libdpkg-perl' to build dependencies
* Disable tests (one of them is failing)
2012-08-26 20:11:24 +02:00
Holger Hans Peter Freyther
8c589d2f51
misc: Fix make distcheck of libosmocore by adding the result to the dist
...
Add the new result file to the EXTRA_DIST.
2012-08-25 22:03:42 +02:00
Harald Welte
30a8ec466c
GSM 04.08: Add 'enum gsm48_bcap_speech_ver'
2012-08-24 23:00:05 +02:00
Harald Welte
c8a0b93939
GSM 04.08: Add support for parsing CSD related bearer capabilities
...
Also adds a test case for both encoder and decoder of this IE
2012-08-24 21:37:59 +02:00
Harald Welte
7ccd3181c5
gsm48_ie: annotate functions with chapter numbers from 04.08 spec
2012-08-24 17:06:08 +02:00
Harald Welte
eed26116c9
GSM 08.58: Add channel modes for transparent data services
2012-08-24 15:36:12 +02:00
Harald Welte
fab0ae9b43
import vty_cmd_string_from_valstr() from osmo-bts
...
This function is able to generate a VTY help string based on an
array of 'struct value_string'.
2012-08-20 18:43:09 +02:00
Holger Hans Peter Freyther
08b286277b
utils: Change semantic of OSMO_MAX/OSMO_MIN to match semantic of a function
...
Add parentheses around the OSMO_MAX and OSMO_MIN macro to match
the behaviour of calling a function. The current version does not
evaluate to what is expected. (OSMO_MAX(3, 2) + 13) currently
results in 3 and not 16.
2012-08-15 17:08:21 +02:00
Harald Welte
335aedabf2
increaes libosmocgsm LIBVERSIN due to gsm_decode_lai() change
2012-08-03 10:51:10 +02:00
Harald Welte
22be129e1e
serial: don't set O_NDELAY, as it is more or less O_NONBLOCK
...
Applications like osmocon will set O_NONBLOCK themselves or have it done
indirectly by registering it with libosmocore/select.c code.
2012-08-03 10:48:22 +02:00
Holger Hans Peter Freyther
d296f4244f
gb: Make suspend_ref a plain uint8_t instead of a uint8_t*
...
The OpenSUSE build is not happy about the uint8_t to uint8_t*
assignment. As the suspend_ref is a mandatory field we can make
it a plain uint8_t. Increase the LIBVERSION as the ABI has changed.
2012-08-03 10:08:02 +02:00
Holger Hans Peter Freyther
5a19bf7ccb
libgb: Link to the libraries used by libgb
...
The Mandriva linker appears to be more strict in enforcing the
as-needed rules. Link to the libraries that are used by libgb.
2012-08-02 21:51:15 +02:00
Holger Hans Peter Freyther
ea8f238f04
vty: Print the string using "%s", string to avoid security issues
...
The Mandriva GCC is more strict about handling format strings, the
copyright string might contain escape sequences and then any memory
could be read.
2012-08-02 21:26:02 +02:00
Harald Welte
b53717f418
Add missing includes to timer_test.c and osmo-auc-gen.c
...
This fixes the build with -Werror-implicit-function-declaration.
taken from malformatted patch of Chí-Thanh Christopher Nguyễn <chithanh@gentoo.org>
2012-08-02 08:42:59 +02:00