From fde9cb31f2239998e322340705cf3d273adf180f Mon Sep 17 00:00:00 2001 From: Gerrit User 1000161 <1000161@035e6965-6537-41bd-912c-053f3cf69326> Date: Wed, 27 Apr 2022 14:20:45 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: (1 comment) Patch-set: 4 Attention: {"person_ident":"Gerrit User 1000161 \u003c1000161@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Hoernchen replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Hoernchen replied on the change"} --- 663d36c62db79e5e8fd4505aacd60356167bd190 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/663d36c62db79e5e8fd4505aacd60356167bd190 b/663d36c62db79e5e8fd4505aacd60356167bd190 index aa71fa2a4..4e085158e 100644 --- a/663d36c62db79e5e8fd4505aacd60356167bd190 +++ b/663d36c62db79e5e8fd4505aacd60356167bd190 @@ -16,6 +16,24 @@ "message": "while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called.\nNot sure if this is really worth it, specially since this may be called lots of times. I\u0027d like others to comment on this.", "revId": "663d36c62db79e5e8fd4505aacd60356167bd190", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "4c68e9d5_041ff04a", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 4 + }, + "lineNbr": 0, + "author": { + "id": 1000161 + }, + "writtenOn": "2022-04-27T14:20:45Z", + "side": 1, + "message": "You\u0027re doing a bit-wise comparison of 212 conescutive bits, instead of just memcmping a few bytes, the % isn\u0027t the issue here...", + "parentUuid": "080a74c8_81648439", + "revId": "663d36c62db79e5e8fd4505aacd60356167bd190", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file