From fca15ebf995bcc8e00263619c0e366384f94881c Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Tue, 25 Jan 2022 16:23:45 +0100 Subject: [PATCH] osmo_libusb: Fix NULL check in osmo_usb_removed_cb() Thread 1 "simtrace2-tool" received signal SIGSEGV, Segmentation fault. 0x00007ffff73dd2a0 in llist_del (entry=0x0) at ../include/osmocom/core/linuxlist.h:130 130 __llist_del(entry->prev, entry->next); (gdb) bt Change-Id: I2b7ab8dddd69453826053663dd5589a941c2e47d --- src/usb/osmo_libusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index 05331a1c4..a6f194adb 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -99,7 +99,7 @@ static void osmo_usb_added_cb(int fd, short events, void *user_data) static void osmo_usb_removed_cb(int fd, void *user_data) { struct osmo_fd *ofd = osmo_fd_get_by_fd(fd); - if (!fd) + if (!ofd) return; osmo_fd_unregister(ofd); talloc_free(ofd);