diff --git a/openbsc/include/openbsc/control_cmd.h b/openbsc/include/openbsc/control_cmd.h index 82252cb6a..24292ead2 100644 --- a/openbsc/include/openbsc/control_cmd.h +++ b/openbsc/include/openbsc/control_cmd.h @@ -80,7 +80,7 @@ struct msgb *ctrl_cmd_make(struct ctrl_cmd *cmd); struct ctrl_cmd *ctrl_cmd_cpy(void *ctx, struct ctrl_cmd *cmd); #define CTRL_CMD_DEFINE_RANGE(cmdname, cmdstr, dtype, element, min, max) \ -int get_##cmdname(struct ctrl_cmd *cmd, void *data) \ +static int get_##cmdname(struct ctrl_cmd *cmd, void *data) \ { \ dtype *node = data; \ cmd->reply = talloc_asprintf(cmd, "%i", node->element); \ @@ -90,14 +90,14 @@ int get_##cmdname(struct ctrl_cmd *cmd, void *data) \ } \ return CTRL_CMD_REPLY; \ } \ -int set_##cmdname(struct ctrl_cmd *cmd, void *data) \ +static int set_##cmdname(struct ctrl_cmd *cmd, void *data) \ { \ dtype *node = data; \ int tmp = atoi(cmd->value); \ node->element = tmp; \ return get_##cmdname(cmd, data); \ } \ -int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data) \ +static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data) \ { \ int tmp = atoi(value); \ if ((tmp >= min)&&(tmp <= max)) { \ @@ -114,7 +114,7 @@ struct ctrl_cmd_element cmd_##cmdname = { \ } #define CTRL_CMD_DEFINE_STRING(cmdname, cmdstr, dtype, element) \ -int get_##cmdname(struct ctrl_cmd *cmd, dtype *data) \ +static int get_##cmdname(struct ctrl_cmd *cmd, dtype *data) \ { \ cmd->reply = talloc_asprintf(cmd, "%s", data->element); \ if (!cmd->reply) { \ @@ -123,7 +123,7 @@ int get_##cmdname(struct ctrl_cmd *cmd, dtype *data) \ } \ return CTRL_CMD_REPLY; \ } \ -int set_##cmdname(struct ctrl_cmd *cmd, dtype *data) \ +static int set_##cmdname(struct ctrl_cmd *cmd, dtype *data) \ { \ bsc_replace_string(cmd->node, &data->element, cmd->value); \ return get_##cmdname(cmd, data); \ @@ -137,9 +137,9 @@ struct ctrl_cmd_element cmd_##cmdname = { \ } #define CTRL_CMD_DEFINE(cmdname, cmdstr) \ -int get_##cmdname(struct ctrl_cmd *cmd, void *data); \ -int set_##cmdname(struct ctrl_cmd *cmd, void *data); \ -int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \ +static int get_##cmdname(struct ctrl_cmd *cmd, void *data); \ +static int set_##cmdname(struct ctrl_cmd *cmd, void *data); \ +static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \ struct ctrl_cmd_element cmd_##cmdname = { \ .name = cmdstr, \ .param = NULL, \ diff --git a/openbsc/src/libctrl/control_if.c b/openbsc/src/libctrl/control_if.c index 49e2ab19e..8198ae6b7 100644 --- a/openbsc/src/libctrl/control_if.c +++ b/openbsc/src/libctrl/control_if.c @@ -436,7 +436,7 @@ oom: /* rate_ctr */ CTRL_CMD_DEFINE(rate_ctr, "rate_ctr *"); -int get_rate_ctr(struct ctrl_cmd *cmd, void *data) +static int get_rate_ctr(struct ctrl_cmd *cmd, void *data) { int intv; unsigned int idx; @@ -529,21 +529,21 @@ err: return CTRL_CMD_ERROR; } -int set_rate_ctr(struct ctrl_cmd *cmd, void *data) +static int set_rate_ctr(struct ctrl_cmd *cmd, void *data) { cmd->reply = "Can't set rate counter."; return CTRL_CMD_ERROR; } -int verify_rate_ctr(struct ctrl_cmd *cmd, const char *value, void *data) +static int verify_rate_ctr(struct ctrl_cmd *cmd, const char *value, void *data) { return 0; } /* counter */ CTRL_CMD_DEFINE(counter, "counter *"); -int get_counter(struct ctrl_cmd *cmd, void *data) +static int get_counter(struct ctrl_cmd *cmd, void *data) { char *ctr_name, *tmp, *dup, *saveptr; struct osmo_counter *counter; @@ -586,7 +586,7 @@ err: return CTRL_CMD_ERROR; } -int set_counter(struct ctrl_cmd *cmd, void *data) +static int set_counter(struct ctrl_cmd *cmd, void *data) { cmd->reply = "Can't set counter."; @@ -594,7 +594,7 @@ int set_counter(struct ctrl_cmd *cmd, void *data) return CTRL_CMD_ERROR; } -int verify_counter(struct ctrl_cmd *cmd, const char *value, void *data) +static int verify_counter(struct ctrl_cmd *cmd, const char *value, void *data) { return 0; }