osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 1000028 2022-10-31 14:03:18 +00:00 committed by Gerrit Code Review
parent cf0fc06333
commit ef825838c2
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
0d9b6b0e31f2d608c9ac18a861a905a94b978702 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "aba8b9ee_4bb094a1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000028
},
"writtenOn": "2022-10-31T14:03:18Z",
"side": 1,
"message": "Its important to click \"done\" when an a comment is resolved.",
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

18
d00b272a6707792e444f7ebb2d374fb09b2bc085
View File

@ -16,6 +16,24 @@
"message": "From my understanding, this is an NSVC related variable. It should not be in the struct of the generic FSM implementaion. We use this FSM everywhere.",
"revId": "d00b272a6707792e444f7ebb2d374fb09b2bc085",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "99e7f9f8_7e796a57",
"filename": "include/osmocom/core/fsm.h",
"patchSetId": 3
},
"lineNbr": 103,
"author": {
"id": 1000028
},
"writtenOn": "2022-10-31T14:03:18Z",
"side": 1,
"message": "Done",
"parentUuid": "f6898024_aedec9d7",
"revId": "d00b272a6707792e444f7ebb2d374fb09b2bc085",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}