osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

gprs_ns2: fix NS STATUS validation 

The wrong TLVs were used.

Change-Id: I01339d93469285cc5340500717ab2b696284e12a
This commit is contained in:
Alexander Couzens 2021-09-06 18:17:15 +02:00
parent 9cd9f6d53f
commit eec4f608b5
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/gb/gprs_ns2_message.c
View File

@ -95,12 +95,11 @@ static int ns2_validate_status(struct gprs_ns2_vc *nsvc, struct msgb *msg, struc
return -1;
}
uint8_t _cause = tlvp_val8(tp, NS_IE_VCI, 0);
uint8_t _cause = tlvp_val8(tp, NS_IE_CAUSE, 0);
switch (_cause) {
case NS_CAUSE_NSVC_BLOCKED:
case NS_CAUSE_NSVC_UNKNOWN:
if (!TLVP_PRES_LEN(tp, NS_IE_CAUSE, 1)) {
if (!TLVP_PRES_LEN(tp, NS_IE_VCI, 1)) {
*cause = NS_CAUSE_MISSING_ESSENT_IE;
return -1;
}
@ -110,7 +109,7 @@ static int ns2_validate_status(struct gprs_ns2_vc *nsvc, struct msgb *msg, struc
case NS_CAUSE_PROTO_ERR_UNSPEC:
case NS_CAUSE_INVAL_ESSENT_IE:
case NS_CAUSE_MISSING_ESSENT_IE:
if (!TLVP_PRES_LEN(tp, NS_IE_CAUSE, 1)) {
if (!TLVP_PRES_LEN(tp, NS_IE_PDU, 1)) {
*cause = NS_CAUSE_MISSING_ESSENT_IE;
return -1;
}