Update patch set 7

Patch Set 7: Code-Review-1

(1 comment)

Patch-set: 7
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-08-12 11:45:11 +00:00 committed by Gerrit Code Review
parent c13714e03e
commit c7f57fd275
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "9bd70bec_97f7ccdc",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-08-12T11:45:11Z",
"side": 1,
"message": "I\u0027m sorry but I see more drawbacks than benefits here. Heap allocation + converting a string addr to a sockaddr and back to a string. Amount of lines still more or less the same. This doesn\u0027t look good to me. If others like this then they will provide enough votes.",
"revId": "c9206aaa19bafd2d4d68d2575ba7bc284524a95d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}