osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

gprs_ns_vty: guard against duplicate VTY elements 

The TbfTest in osmo-pcu calls gprs_ns_vty_init() repeatedly, which aborts
because of duplicate VTY elements. Fix this by skipping the VTY init if
it already happened.

Change-Id: I05c7f25a4e873ae76b206819180b8b043b60103e
This commit is contained in:
Neels Hofmeyr 2017-01-12 22:32:19 +01:00
parent 1251afe254
commit c32bfd5824
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gb/gprs_ns_vty.c
View File

@ -573,8 +573,16 @@ DEFUN(logging_fltr_nsvc,
int gprs_ns_vty_init(struct gprs_ns_inst *nsi)
{
static bool vty_elements_installed = false;
vty_nsi = nsi;
/* Regression test code may call this function repeatedly, so make sure
* that VTY elements are not duplicated, which would assert. */
if (vty_elements_installed)
return 0;
vty_elements_installed = true;
install_element_ve(&show_ns_cmd);
install_element_ve(&show_ns_stats_cmd);
install_element_ve(&show_nse_cmd);