osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

socket: Avoid aborting socket creation if setsockopt for ASCONF fails 

Avoid aborting the entire socket creation, since those sockopt are fairly
new in the kernel (v5.4), and the feature can still be enabled in older
versions system-wide with sysctl. The worst it can happen is that the
ability to submit address updates (such as Peer Primary Address) doesn't
work, which is not really critical.

Related: SYS#6501
Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65
This commit is contained in:
Pau Espin 2023-08-28 13:56:25 +02:00
parent f91d2aac9d
commit b437f80e89
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/socket.c
View File

@ -850,7 +850,8 @@ int osmo_sock_init2_multiaddr(uint16_t family, uint16_t type, uint8_t proto,
LOGP(DLGLOBAL, LOGL_ERROR,
"cannot setsockopt(SCTP_AUTH_SUPPORTED) socket: %s:%u: %s\n",
strbuf, local_port, strerror(err));
goto ret_close;
/* do not fail, some features such as Peer Primary Address won't be available
* unless configured system-wide through sysctl */
}
rc = setsockopt_sctp_asconf_supported(sfd);
@ -860,7 +861,8 @@ int osmo_sock_init2_multiaddr(uint16_t family, uint16_t type, uint8_t proto,
LOGP(DLGLOBAL, LOGL_ERROR,
"cannot setsockopt(SCTP_ASCONF_SUPPORTED) socket: %s:%u: %s\n",
strbuf, local_port, strerror(err));
goto ret_close;
/* do not fail, some features such as Peer Primary Address won't be available
* unless configured system-wide through sysctl */
}
}