Update patch set 9

Patch Set 9:

(6 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
changes/93/28993/meta
Gerrit User 1000159 2 months ago committed by Gerrit Code Review
parent 77c341a6d1
commit b32ca4e9bc
  1. 132
      e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0

@ -40,6 +40,30 @@
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "4f88114f_3d679a33",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 206,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "d53f555c_f92e43e0",
"range": {
"startLine": 206,
"startChar": 3,
"endLine": 206,
"endChar": 10
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -57,6 +81,24 @@
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "1bbaa60a_5f2764e9",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 211,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "929275f4_7dc7d54a",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -74,6 +116,24 @@
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "cabdfc50_85dde7a2",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 220,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Seems rather pointless to me: that\u0027s a static function with only few invocations, not part of public API so we don\u0027t have to insure against user who failed to read the docs.",
"parentUuid": "e19adda9_0983c84b",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -97,6 +157,30 @@
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ee49f2e0_1692bab0",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 236,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "That seems like odd side-effect to me for which I couldn\u0027t find any tests. Having NULL input we can\u0027t guess whether IPv4 or IPv6 address to show. Moreover, print helper seems like a wrong place for such guesswork in a first place - the caller have more context information and can pass proper default explicitly. I\u0027ll update commit message to make it more visible.",
"parentUuid": "1504e0df_a1cc8835",
"range": {
"startLine": 236,
"startChar": 3,
"endLine": 236,
"endChar": 16
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -120,6 +204,30 @@
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "610e45fc_467ccb3f",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 241,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "eb09c2cb_42c8e947",
"range": {
"startLine": 241,
"startChar": 19,
"endLine": 241,
"endChar": 29
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -142,6 +250,30 @@
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "4c36e3d1_1f51e592",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 749,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-01T16:07:50Z",
"side": 1,
"message": "Done",
"parentUuid": "eeab4d3a_6d3e68f1",
"range": {
"startLine": 749,
"startChar": 49,
"endLine": 749,
"endChar": 52
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}
Loading…
Cancel
Save