From af90103299e963b1a23fb940d5ff97957d5c84bf Mon Sep 17 00:00:00 2001
From: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
Date: Wed, 9 Nov 2022 02:27:25 +0700
Subject: [PATCH] */Makefile.am: do not mix up AM_CFLAGS with AM_CPPFLAGS

Change-Id: I2c1d5f9c61714f487fbbe60603b2682f2c0a4c6b
---
 src/codec/Makefile.am        | 4 ++--
 src/coding/Makefile.am       | 5 ++---
 src/ctrl/Makefile.am         | 3 ++-
 src/gsm/Makefile.am          | 6 +++---
 src/pseudotalloc/Makefile.am | 3 ++-
 utils/Makefile.am            | 4 ++--
 6 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/codec/Makefile.am b/src/codec/Makefile.am
index b712591e1..de8de1bf8 100644
--- a/src/codec/Makefile.am
+++ b/src/codec/Makefile.am
@@ -3,8 +3,8 @@
 # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
 LIBVERSION=3:1:3
 
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS)
-AM_CFLAGS = -Wall
+AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
 
 if ENABLE_PSEUDOTALLOC
 AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc
diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am
index 9a24f3890..5ce3cbfc0 100644
--- a/src/coding/Makefile.am
+++ b/src/coding/Makefile.am
@@ -5,9 +5,8 @@ LIBVERSION=2:0:2
 
 AM_CPPFLAGS = \
 	-I"$(top_srcdir)/include" \
-	-I"$(top_builddir)/include" \
-	$(TALLOC_CFLAGS)
-AM_CFLAGS = -Wall
+	-I"$(top_builddir)/include"
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
 
 if ENABLE_PSEUDOTALLOC
 AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc
diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am
index 5921f048c..e53594d48 100644
--- a/src/ctrl/Makefile.am
+++ b/src/ctrl/Makefile.am
@@ -3,7 +3,8 @@
 # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
 LIBVERSION=7:0:7
 
-AM_CFLAGS = -Wall $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS)
+AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
 
 if ENABLE_CTRL
 lib_LTLIBRARIES = libosmoctrl.la
diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am
index a3820d750..0d66476d9 100644
--- a/src/gsm/Makefile.am
+++ b/src/gsm/Makefile.am
@@ -3,8 +3,8 @@
 # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
 LIBVERSION=18:0:0
 
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS)
-AM_CFLAGS = -Wall
+AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
 
 if ENABLE_PSEUDOTALLOC
 AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc
@@ -43,7 +43,7 @@ libosmogsm_la_LDFLAGS = $(LTLDFLAGS_OSMOGSM) -version-info $(LIBVERSION) -no-und
 libosmogsm_la_LIBADD = libgsmint.la $(TALLOC_LIBS)
 
 if ENABLE_GNUTLS
-AM_CPPFLAGS += $(LIBGNUTLS_CFLAGS)
+AM_CFLAGS += $(LIBGNUTLS_CFLAGS)
 libosmogsm_la_LIBADD += $(LIBGNUTLS_LIBS)
 else
 noinst_HEADERS += kdf/sha1.h kdf/sha256.h kdf/common.h kdf/sha1_i.h kdf/sha256_i.h
diff --git a/src/pseudotalloc/Makefile.am b/src/pseudotalloc/Makefile.am
index 3c78bba88..b631eca9c 100644
--- a/src/pseudotalloc/Makefile.am
+++ b/src/pseudotalloc/Makefile.am
@@ -1,4 +1,5 @@
-AM_CFLAGS = -Wall -I. $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CPPFLAGS = -I. $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CFLAGS = -Wall
 
 if ENABLE_PSEUDOTALLOC
 
diff --git a/utils/Makefile.am b/utils/Makefile.am
index 3f2b13f6a..47c5a78ca 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -1,8 +1,8 @@
 
 bin_PROGRAMS =
 noinst_PROGRAMS =
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS)
-AM_CFLAGS = -Wall $(PTHREAD_CFLAGS)
+AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS)
 LDADD = $(top_builddir)/src/libosmocore.la $(top_builddir)/src/gsm/libosmogsm.la $(PTHREAD_LIBS)
 
 if ENABLE_UTILITIES