osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4: Code-Review+2

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000229 <1000229@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"arehbein replied on the change"}
This commit is contained in:
Gerrit User 1000229 2022-11-01 14:37:29 +00:00 committed by Gerrit Code Review
parent 284365696b
commit ae4eacabb2
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
0d9b6b0e31f2d608c9ac18a861a905a94b978702
View File

@ -51,6 +51,23 @@
"message": "I tend to ignore the gerrit \"Done\" stuff as much as i can. it is possible to vote and merge a patch without clicking \"Done\" on all comments. I guess it is intended as a helpful feature but i\u0027m not feeling it.\n\n(Particularly, i find the UI to check-mark a number of N separate comments as \"Done\" really annoying.\nNot all comments mean that something needs to be done. The magic that implicitly marks things as done / undone is sometimes leading to wrong markings. Or a patch owner marks things as Done without actually having addressed the comment. So i do not let that tick mark UI hog my attention.)",
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "19693a1e_e6e5fb73",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000229
},
"writtenOn": "2022-11-01T14:37:29Z",
"side": 1,
"message": "Two CR+1\u0027s",
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}