osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

signal.c: Fix osmo_signal_talloc_ctx_init() 

This function is broken ever since it was added back in 2018 in commit
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09

Rather than allocating from the user-supplied 'root_ctx', it is
allocating from the context that it's trying to create (which is
NULL at that time, rendering the entire operation more or less
a no-op.  For sure you will not see osmo_signal structures never in
any talloc report.

Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
This commit is contained in:
Harald Welte 2019-03-20 11:26:58 +01:00
parent 1688699c3f
commit 8c58af139d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/signal.c
View File

@ -52,7 +52,7 @@ struct signal_handler {
* \returns the new osmo_signal talloc context, e.g. for reporting
*/
void *osmo_signal_talloc_ctx_init(void *root_ctx) {
tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal");
tall_sigh_ctx = talloc_named_const(root_ctx, 0, "osmo_signal");
return tall_sigh_ctx;
}