osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

logging: remove workaround now that _output() has been reworked 

This patch removes a workaround to fix some strange memory corruption
now that _output() has been completely reworked and we make use of
snprintf appropriately.
This commit is contained in:
Pablo Neira Ayuso 2011-05-03 22:32:48 +02:00 committed by Harald Welte
parent 7503fb8e3e
commit 81e9636454
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/logging.c
View File

@ -221,19 +221,10 @@ static void _logp(unsigned int subsys, int level, char *file, int line,
else if (osmo_log_info->filter_fn)
output = osmo_log_info->filter_fn(&log_context,
tar);
if (!output)
continue;
if (output) {
/* FIXME: copying the va_list is an ugly
* workaround against a bug hidden somewhere in
* _output. If we do not copy here, the first
* call to _output() will corrupt the va_list
* contents, and any further _output() calls
* with the same va_list will segfault */
va_list bp;
va_copy(bp, ap);
_output(tar, subsys, level, file, line, cont, format, bp);
va_end(bp);
}
_output(tar, subsys, level, file, line, cont, format, ap);
}
}