Update patch set 9

Patch Set 9:

(6 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"fixeria replied on the change"}
changes/93/28993/meta
Gerrit User 1000010 2 months ago committed by Gerrit Code Review
parent 3e5829f9ff
commit 77c341a6d1
  1. 126
      e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0

@ -16,6 +16,132 @@
"message": "Updated static helper instead of creating new function as requested in feedback.",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d53f555c_f92e43e0",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 206,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "There is no \u0027buf_len\u0027 anymore. And it looks like this comment was initially incorrect: it should be host_count/addrs_count I guess?",
"range": {
"startLine": 206,
"startChar": 3,
"endLine": 206,
"endChar": 10
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "929275f4_7dc7d54a",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 211,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "cosmetic: alignment needs to be fixed here",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e19adda9_0983c84b",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 220,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the same time.",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1504e0df_a1cc8835",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 236,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "Before your patch this function would print \"0.0.0.0\" if hosts[i] is NULL.\nYou\u0027re changing it to not print anything. What\u0027s your motivation?",
"range": {
"startLine": 236,
"startChar": 3,
"endLine": 236,
"endChar": 16
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "eb09c2cb_42c8e947",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 241,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "LOGL_ERROR? Not sure if we need to log anything here though.",
"range": {
"startLine": 241,
"startChar": 19,
"endLine": 241,
"endChar": 29
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "eeab4d3a_6d3e68f1",
"filename": "src/socket.c",
"patchSetId": 9
},
"lineNbr": 749,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-29T07:56:27Z",
"side": 1,
"message": "Better do sizeof(strbuf).",
"range": {
"startLine": 749,
"startChar": 49,
"endLine": 749,
"endChar": 52
},
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}
Loading…
Cancel
Save