From 74d7fe4f4a961d0734621f32d205986586fd6b41 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326> Date: Wed, 26 Oct 2022 22:31:53 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"} --- 24ec86496b5089567798bd3bdeb698fbfd726bee | 36 ++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/24ec86496b5089567798bd3bdeb698fbfd726bee b/24ec86496b5089567798bd3bdeb698fbfd726bee index 1cecabd7f..3538c8ff5 100644 --- a/24ec86496b5089567798bd3bdeb698fbfd726bee +++ b/24ec86496b5089567798bd3bdeb698fbfd726bee @@ -68,6 +68,24 @@ "revId": "24ec86496b5089567798bd3bdeb698fbfd726bee", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": true, + "key": { + "uuid": "fffb715d_f470169e", + "filename": "src/gsm/gsm0808_utils.c", + "patchSetId": 2 + }, + "lineNbr": 1612, + "author": { + "id": 1000005 + }, + "writtenOn": "2022-10-26T22:31:53Z", + "side": 1, + "message": "it is possible, for example some modes are disabled for HR,\nand some are completely disabled for GSM.\nThis check makes sure we don\u0027t set an S bit when s_modes is empty.", + "parentUuid": "a93337f0_892ab592", + "revId": "24ec86496b5089567798bd3bdeb698fbfd726bee", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -84,6 +102,24 @@ "message": "don\u0027t you need to \"s15_s0 \u0026 (1\u003c\u003cs_bit)\" here?", "revId": "24ec86496b5089567798bd3bdeb698fbfd726bee", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "3706a808_7492bb4c", + "filename": "src/gsm/gsm0808_utils.c", + "patchSetId": 2 + }, + "lineNbr": 1635, + "author": { + "id": 1000005 + }, + "writtenOn": "2022-10-26T22:31:53Z", + "side": 1, + "message": "thanks, nice catch.", + "parentUuid": "32e5b546_7f94f885", + "revId": "24ec86496b5089567798bd3bdeb698fbfd726bee", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file