osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
This commit is contained in:
Gerrit User 1000005 2022-10-26 22:31:53 +00:00 committed by Gerrit Code Review
parent 72c73b379e
commit 74d7fe4f4a
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
24ec86496b5089567798bd3bdeb698fbfd726bee
View File

@ -68,6 +68,24 @@
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "fffb715d_f470169e",
"filename": "src/gsm/gsm0808_utils.c",
"patchSetId": 2
},
"lineNbr": 1612,
"author": {
"id": 1000005
},
"writtenOn": "2022-10-26T22:31:53Z",
"side": 1,
"message": "it is possible, for example some modes are disabled for HR,\nand some are completely disabled for GSM.\nThis check makes sure we don\u0027t set an S bit when s_modes is empty.",
"parentUuid": "a93337f0_892ab592",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -84,6 +102,24 @@
"message": "don\u0027t you need to \"s15_s0 \u0026 (1\u003c\u003cs_bit)\" here?",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "3706a808_7492bb4c",
"filename": "src/gsm/gsm0808_utils.c",
"patchSetId": 2
},
"lineNbr": 1635,
"author": {
"id": 1000005
},
"writtenOn": "2022-10-26T22:31:53Z",
"side": 1,
"message": "thanks, nice catch.",
"parentUuid": "32e5b546_7f94f885",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}