osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2:

(4 comments)

Patch-set: 2
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
changes/75/29475/meta
Gerrit User 1000074 2022-09-27 09:11:56 +00:00 committed by Gerrit Code Review
parent aa7bb6c98d
commit 72c73b379e
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
24ec86496b5089567798bd3bdeb698fbfd726bee
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8f28a2f7_8f218681",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 17,
"author": {
"id": 1000074
},
"writtenOn": "2022-09-27T09:11:56Z",
"side": 1,
"message": "\"gsm0808_sc_cfg_amr_modes\" or \"gsm0808_sc_cfg_mr_modes\" would be far more descriptive.",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
@ -16,6 +33,57 @@
"message": "(only pushed again to resolve the bogus \"merge conflict\" that gerrit indicated)",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4372a7cb_f8e4a287",
"filename": "include/osmocom/gsm/protocol/gsm_04_08.h",
"patchSetId": 2
},
"lineNbr": 627,
"author": {
"id": 1000074
},
"writtenOn": "2022-09-27T09:11:56Z",
"side": 1,
"message": "can you better add a union with a field containing the whole octet in the struct gsm48_multi_rate_conf?",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a93337f0_892ab592",
"filename": "src/gsm/gsm0808_utils.c",
"patchSetId": 2
},
"lineNbr": 1612,
"author": {
"id": 1000074
},
"writtenOn": "2022-09-27T09:11:56Z",
"side": 1,
"message": "can it happen that s_modes is 0 here?",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "32e5b546_7f94f885",
"filename": "src/gsm/gsm0808_utils.c",
"patchSetId": 2
},
"lineNbr": 1635,
"author": {
"id": 1000074
},
"writtenOn": "2022-09-27T09:11:56Z",
"side": 1,
"message": "don\u0027t you need to \"s15_s0 \u0026 (1\u003c\u003cs_bit)\" here?",
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}