From 6f3b738c74158461387bd3ee40a240ef3d99b1a5 Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Mon, 21 Dec 2020 15:57:04 +0100 Subject: [PATCH] gprs_ns2: don't start unconfigured fsm via FORCE_UNCONFIGURED IP-SNS NSVC are unconfigured and not started when the IP-SNS is doing the SNS configuration. If those NSVC would be started it would result in unsolicitated NS-Alive PDUs. Change-Id: Ifec7288dbe71f10109e8b5c3849bf8f23ac7b557 --- src/gb/gprs_ns2_vc_fsm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c index 0f6eeabd8..d5f134e10 100644 --- a/src/gb/gprs_ns2_vc_fsm.c +++ b/src/gb/gprs_ns2_vc_fsm.c @@ -566,10 +566,12 @@ static void gprs_ns2_vc_fsm_allstate_action(struct osmo_fsm_inst *fi, msgb_free(msg); break; case GPRS_NS2_EV_FORCE_UNCONFIGURED: - /* Force the NSVC back to its initial state */ - osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_UNCONFIGURED, 0, 0); - osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_START, NULL); - return; + if (fi->state != GPRS_NS2_ST_UNCONFIGURED) { + /* Force the NSVC back to its initial state */ + osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_UNCONFIGURED, 0, 0); + osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_START, NULL); + return; + } break; } }