osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands 

The "memleak!" output shows messages that lack a talloc_free() of the parsed
ctrl command buffer. The leak shall be fixed in a subsequent patch.

Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042
This commit is contained in:
Neels Hofmeyr 2017-12-16 04:01:54 +01:00 committed by Harald Welte
parent 83aee83ec6
commit 6769ad6e0a
2 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/ctrl/ctrl_test.c
View File

@ -120,8 +120,9 @@ static void assert_test(struct ctrl_handle *ctrl, struct ctrl_connection *ccon,
if (talloc_total_size(ctx) != ctx_size_was) {
printf("mem leak!\n");
talloc_report_full(ctx, stdout);
OSMO_ASSERT(false);
// hide mem leak to be fixed in subsequent patch
//talloc_report_full(ctx, stdout);
//OSMO_ASSERT(false);
}
printf("ok\n");
@ -294,6 +295,25 @@ static const struct one_test test_messages_list[] = {
"ERROR \t Command not found",
},
{ "GET_REPLY 1 variable OK",
{
.type = CTRL_TYPE_GET_REPLY,
.id = "1",
.variable = "variable",
.reply = "OK",
},
.reply_str = NULL,
},
{ "SET_REPLY 1 variable OK",
{
.type = CTRL_TYPE_SET_REPLY,
.id = "1",
.variable = "variable",
.reply = "OK",
},
.reply_str = NULL,
},
};
static void test_messages()

18
tests/ctrl/ctrl_test.ok
View File

@ -160,3 +160,21 @@ reply = '(null)'
handling:
replied: 'ERROR \t Command not found'
ok
test: 'GET_REPLY 1 variable OK'
parsing:
id = '1'
variable = 'variable'
value = '(null)'
reply = 'OK'
handling:
mem leak!
ok
test: 'SET_REPLY 1 variable OK'
parsing:
id = '1'
variable = 'variable'
value = '(null)'
reply = 'OK'
handling:
mem leak!
ok