From 65f06e0950a6483774f6bf90955106c1da0ff54a Mon Sep 17 00:00:00 2001
From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Date: Mon, 27 Nov 2023 16:47:28 +0000
Subject: [PATCH] Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
---
 4e289a9ff84904e1e5144942ab77d03a93dfe39c | 21 +++++++++++++++++++++
 effc3bad398e43220412258af2d9ae123d2e1257 | 18 ++++++++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 4e289a9ff84904e1e5144942ab77d03a93dfe39c

diff --git a/4e289a9ff84904e1e5144942ab77d03a93dfe39c b/4e289a9ff84904e1e5144942ab77d03a93dfe39c
new file mode 100644
index 000000000..363436df7
--- /dev/null
+++ b/4e289a9ff84904e1e5144942ab77d03a93dfe39c
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "b6aff731_e86e10c4",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-11-27T16:47:28Z",
+      "side": 1,
+      "message": "I have the feeling this patch is wrong, in the sense that we are adding tons of SCTP specific stuff here which actually seem to be more generic (cmsg) in the existing layer.\nSo I\u0027d appreciate the idea of thinking whether we can keep the API generic (cms based) instead of putting lots of SCTP stuff in there. Becuase in the end we are not really calling any libsctp API....",
+      "revId": "4e289a9ff84904e1e5144942ab77d03a93dfe39c",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}
\ No newline at end of file
diff --git a/effc3bad398e43220412258af2d9ae123d2e1257 b/effc3bad398e43220412258af2d9ae123d2e1257
index 34ed5f91e..0cc30d740 100644
--- a/effc3bad398e43220412258af2d9ae123d2e1257
+++ b/effc3bad398e43220412258af2d9ae123d2e1257
@@ -51,6 +51,24 @@
       "parentUuid": "c5e72766_e3dd5ce1",
       "revId": "effc3bad398e43220412258af2d9ae123d2e1257",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "eafa464a_9b8c3ef2",
+        "filename": "src/core/osmo_io_internal.h",
+        "patchSetId": 1
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-11-27T16:47:28Z",
+      "side": 1,
+      "message": "Agree to do \"if HAVE_LIBSCTP\" here.",
+      "parentUuid": "8f12394c_9f18aa1a",
+      "revId": "effc3bad398e43220412258af2d9ae123d2e1257",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file