diff --git a/80a6e351e5f15d81ad00682c0a862c02bc223bc0 b/80a6e351e5f15d81ad00682c0a862c02bc223bc0 index 164214cea..666145fc9 100644 --- a/80a6e351e5f15d81ad00682c0a862c02bc223bc0 +++ b/80a6e351e5f15d81ad00682c0a862c02bc223bc0 @@ -16,6 +16,24 @@ "message": "IMHO this causes even more difficulties to understand FSM code (both the FSM implementation and users of the FSM) by having to look at yet another place for flow of events.\n\nI think it\u0027s totally fine having to add the possible events on each state, it helps understanding what may be possible by readers who look at it.\nLogging incorrect events sent at a given point is also good, because it allows learning that some scenarios are also possible and need to be taken into account.\n\nSo my opinion right now is that I see no need for this change. Other feel free to provide their own opinion on the topic.", "revId": "80a6e351e5f15d81ad00682c0a862c02bc223bc0", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "fa0948ee_2b67e8b1", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 3 + }, + "lineNbr": 0, + "author": { + "id": 1000015 + }, + "writtenOn": "2022-10-28T16:00:39Z", + "side": 1, + "message": "I find it very difficult to write empty events in many states (both in the in_event_mask and within the state function). Or having proxy functions which checks if the fsm might be in the right state to emit a signal. Those log lines also confuses the user as we\u0027ve seen in redmine tickets (e.g. sgsn, ns layer).", + "parentUuid": "8247f8a8_a7130cfc", + "revId": "80a6e351e5f15d81ad00682c0a862c02bc223bc0", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file