osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000015 \u003c1000015@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
This commit is contained in:
Gerrit User 1000004 2022-10-28 16:53:29 +00:00 committed by Gerrit Code Review
parent 5aeaf7031f
commit 4c231792f7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
80a6e351e5f15d81ad00682c0a862c02bc223bc0
View File

@ -34,6 +34,24 @@
"parentUuid": "8247f8a8_a7130cfc",
"revId": "80a6e351e5f15d81ad00682c0a862c02bc223bc0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f6c67a3a_3e4f1841",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2022-10-28T16:53:29Z",
"side": 1,
"message": "I am also sceptical regarding this change, sorry.\n\n* if we have misleading log messages, and users report them, it is good so the code can be fixed. To me, any of those messages occuring during normal operation means that the FSM hasn\u0027t been properly completed yet, and it should draw attention to the developer. Ideally we wouldn\u0027t have to go via users, but developers would notice themselves, of course.\n\n* adding more and more \"obscure options\" ot the FSM makes it more and more difficult to use it right.",
"parentUuid": "fa0948ee_2b67e8b1",
"revId": "80a6e351e5f15d81ad00682c0a862c02bc223bc0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}