osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Verified+1 Code-Review+2

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 1000147 <1000147@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Label: Verified=+1
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"osmith replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"osmith replied on the change"}
This commit is contained in:
Gerrit User 1000147 2022-11-07 09:23:05 +00:00 committed by Gerrit Code Review
parent 0ab0e1fc60
commit 32bac48b5a
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
8d5fc1db44ee18d2881c461cc6ebdc650468ad8c
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "6f3caaf8_23c6cece",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2022-11-07T09:23:05Z",
"side": 1,
"message": "Patch looks good. Also I\u0027ve reproduced the error locally and verified that this fixes it with osmo-pcu.",
"revId": "8d5fc1db44ee18d2881c461cc6ebdc650468ad8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -34,6 +51,24 @@
"parentUuid": "a8bf64b3_84cc3492",
"revId": "8d5fc1db44ee18d2881c461cc6ebdc650468ad8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "eb42158c_6a337eb4",
"filename": "include/osmocom/vty/logging.h",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 1000147
},
"writtenOn": "2022-11-07T09:23:05Z",
"side": 1,
"message": "oh right, nvm",
"parentUuid": "e57d4de5_00459c06",
"revId": "8d5fc1db44ee18d2881c461cc6ebdc650468ad8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}