From 21056103db996f470b6ffb20960d463708f4f766 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000159 <1000159@035e6965-6537-41bd-912c-053f3cf69326> Date: Fri, 12 Aug 2022 10:57:59 +0000 Subject: [PATCH] Update patch set 7 Patch Set 7: (1 comment) Patch-set: 7 Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"msuraev replied on the change"} Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"msuraev replied on the change"} --- df43910c8f6b3edfeb985f391b15632e04a75a41 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/df43910c8f6b3edfeb985f391b15632e04a75a41 b/df43910c8f6b3edfeb985f391b15632e04a75a41 index a3d9863c7..29df42dc9 100644 --- a/df43910c8f6b3edfeb985f391b15632e04a75a41 +++ b/df43910c8f6b3edfeb985f391b15632e04a75a41 @@ -16,6 +16,24 @@ "message": "What do we win with this? I see only drawbacks: allocating and freeing N more buffers on the heap everytime it is called.", "revId": "df43910c8f6b3edfeb985f391b15632e04a75a41", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "b6fc0b29_1b59f0eb", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 6 + }, + "lineNbr": 0, + "author": { + "id": 1000159 + }, + "writtenOn": "2022-08-12T10:57:59Z", + "side": 1, + "message": "We gain decrease of code duplication - we use the same function which is also used in other place in the follow-up patches. I don\u0027t think heap alloc matter - that code is called only at the socket init and the number of sockets is a limited resource so it\u0027s very unlikely to ever end up on a hot codepath.", + "parentUuid": "f0224e4c_231aaeff", + "revId": "df43910c8f6b3edfeb985f391b15632e04a75a41", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file