osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present 

When no remaining signalling NSVCs are available the SNS must be
restarted (BSS) or go into unconfigured state (SGSN).

Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8
This commit is contained in:
Alexander Couzens 2021-07-20 22:16:09 +02:00
parent 8a612de92b
commit 1adfd23290
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/gb/gprs_ns2_sns.c
View File

@ -201,6 +201,7 @@ static void _sns_failed(struct osmo_fsm_inst *fi, const char *reason, const char
if (reason)
LOGPFSMLSRC(fi, LOGL_ERROR, file, line, "NSE %d: SNS failed: %s\n", gss->nse->nsei, reason);
gss->alive = false;
if (gss->role == GPRS_SNS_ROLE_SGSN) {
if (!gss->nse->persistent)
gprs_ns2_free_nse(gss->nse);
@ -2599,19 +2600,33 @@ void ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bo
if (gss->block_no_nsvc_events)
return;
if (alive == gss->alive)
if (gss->alive && nse->sum_sig_weight == 0) {
sns_failed(nse->bss_sns_fi, "No signalling NSVC available");
return;
}
/* check if this is the current SNS NS-VC */
if (nsvc == gss->sns_nsvc) {
if (nsvc == gss->sns_nsvc && !alive) {
/* only replace the SNS NS-VC if there are other alive NS-VC.
* There aren't any other alive NS-VC when the SNS fsm just reached CONFIGURED
* and couldn't confirm yet if the NS-VC comes up */
if (gss->alive && !alive)
ns2_sns_replace_nsvc(nsvc);
llist_for_each_entry(tmp, &nse->nsvc, list) {
if (nsvc == tmp)
continue;
if (ns2_vc_is_unblocked(nsvc)) {
ns2_sns_replace_nsvc(nsvc);
break;
}
}
}
if (alive == gss->alive)
return;
if (alive) {
/* we need at least a signalling NSVC before become alive */
if (nse->sum_sig_weight == 0)
return;
gss->alive = true;
osmo_fsm_inst_dispatch(nse->bss_sns_fi, NS2_SNS_EV_REQ_NSVC_ALIVE, NULL);
} else {