From 14aadd5b6f12dddd055a7c82c19df4b5ec119843 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 12 Jun 2019 18:34:34 +0200 Subject: [PATCH] vty: tests: Verify incomplete optional parameters are passed to vty funcs The test shows that in the case were "single0 on" is executed, VTY function should return complete "single0 one" but it doesn't. Related: OS#4045 Change-Id: Ib5b9dc07e2b280dc95011b3926afb1d490cadd81 --- tests/vty/vty_transcript_test.c | 9 +++++++++ tests/vty/vty_transcript_test.vty | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c index 7ffe713af..6651097e0 100644 --- a/tests/vty/vty_transcript_test.c +++ b/tests/vty/vty_transcript_test.c @@ -154,6 +154,14 @@ const struct log_info log_info = { .num_cat = ARRAY_SIZE(default_categories), }; +DEFUN(single0, single0_cmd, + "single0 [one]", + "single0 test command\n" "1\n") +{ + vty_out(vty, "ok argc=%d%s%s%s", argc, argc ? " " : "", argc ? argv[0] : "", VTY_NEWLINE); + return CMD_SUCCESS; +} + DEFUN(multi0, multi0_cmd, "multi0 (one|two|three)", "multi0 test command\n" "1\n2\n3\n") @@ -180,6 +188,7 @@ DEFUN(multi2, multi2_cmd, static void init_vty_cmds() { + install_element_ve(&single0_cmd); install_element_ve(&multi0_cmd); install_element_ve(&multi1_cmd); install_element_ve(&multi2_cmd); diff --git a/tests/vty/vty_transcript_test.vty b/tests/vty/vty_transcript_test.vty index 5ed3c1d76..155774463 100644 --- a/tests/vty/vty_transcript_test.vty +++ b/tests/vty/vty_transcript_test.vty @@ -75,3 +75,12 @@ ok argc=1 on vty_transcript_test> multi2 t % Ambiguous command. + +vty_transcript_test> single0 one +ok argc=1 one + +vty_transcript_test> single0 on +ok argc=1 on + +vty_transcript_test> single0 +ok argc=0