osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

gsm0408_test: Fix IMEI-SV related tests to use no more than 16 digits 

The IMEI-SV is speified as a 16 digit number: 14 digits of IMEI plus
two digits of software version.  Let's not try to feed 18 digit long
numbers into our functions, as the resulting behavior is unspecified.

Change-Id: I6fb85a0516dc387902ad9de4fe8c1ba82d68cae6
This commit is contained in:
Harald Welte 2019-01-20 13:41:26 +01:00
parent d4c406a04e
commit 1317771c93
2 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/gsm0408/gsm0408_test.c
View File

@ -422,17 +422,17 @@ static const struct test_mid_encode_decode_test test_mid_encode_decode_tests[] =
},
{
.mi_type = GSM_MI_TYPE_IMEISV,
.mi_str = "987654321098765432",
.mi_name = "IMEI-SV-987654321098765432",
.expect_mi_tlv_hex = "170a937856341290785634f2",
.mi_str = "9876543210987654",
.mi_name = "IMEI-SV-9876543210987654",
.expect_mi_tlv_hex = "17099378563412907856f4",
},
{
.mi_type = GSM_MI_TYPE_IMEISV,
.mi_str = "987654321098765432",
.mi_name = "IMEI-SV-987654321098765432",
.expect_mi_tlv_hex = "170a937856341290785634f2",
.str_size = 16,
.expect_str = "987654321098765",
.mi_str = "9876543210987654",
.mi_name = "IMEI-SV-9876543210987654",
.expect_mi_tlv_hex = "17099378563412907856f4",
.str_size = 17,
.expect_str = "9876543210987654",
},
{
/* gsm48 treats TMSI as decimal string */

16
tests/gsm0408/gsm0408_test.ok
View File

@ -40,14 +40,14 @@ Testing Mobile Identity conversions
-> MI-TLV-hex='17089a78563412907856'
-> MI-str="987654321098765" rc=16
-> MI-name="IMEI-987654321098765"
- IMEI-SV 987654321098765432
-> MI-TLV-hex='170a937856341290785634f2'
-> MI-str="987654321098765432" rc=19
-> MI-name="IMEI-SV-987654321098765432"
- IMEI-SV 987654321098765432
-> MI-TLV-hex='170a937856341290785634f2'
-> MI-str="987654321098765" rc=16
-> MI-name="IMEI-SV-987654321098765432"
- IMEI-SV 9876543210987654
-> MI-TLV-hex='17099378563412907856f4'
-> MI-str="9876543210987654" rc=17
-> MI-name="IMEI-SV-9876543210987654"
- IMEI-SV 9876543210987654
-> MI-TLV-hex='17099378563412907856f4'
-> MI-str="9876543210987654" rc=17
-> MI-name="IMEI-SV-9876543210987654"
- TMSI 305419896
-> MI-TLV-hex='1705f412345678'
-> MI-str="305419896" rc=9