osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

protocol/gsm_04_08.h: drop incorrect GSM48_PDISC_USSD 

According to the GSM TS 04.07, section 11.2.3.1.1 "Protocol
discriminator", bits 1 to 4 of the first octet of a standard
L3 message contain the protocol discriminator IE.

Meanwhile, the GSM48_PDISC_USSD represents value 0x11, i.e.
0b10001, that requires 5 bits, and moreover it is not
documented anywhere. Let's drop it.

Change-Id: Ic4eb8a6db4ff1dfd535bd0c84e7acf1908422f64
This commit is contained in:
Vadim Yanitskiy 2018-04-17 10:40:27 +07:00 committed by Harald Welte
parent 0b2c0ecd5e
commit 07bfd565a8
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/osmocom/gsm/protocol/gsm_04_08.h
View File

@ -977,7 +977,6 @@ struct gsm48_rr_status {
#define GSM48_PDISC_EXTEND 0x0e
#define GSM48_PDISC_TEST 0x0f /* as per 11.10, 04.14 */
#define GSM48_PDISC_MASK 0x0f
#define GSM48_PDISC_USSD 0x11
extern const struct value_string gsm48_pdisc_names[];
static inline const char *gsm48_pdisc_name(uint8_t val)

1
src/gsm/gsm48.c
View File

@ -775,7 +775,6 @@ const struct value_string gsm48_pdisc_names[] = {
{ GSM48_PDISC_LOC, "LCS" },
{ GSM48_PDISC_EXTEND, "EXTD" },
{ GSM48_PDISC_MASK, "MASK" },
{ GSM48_PDISC_USSD, "USSD" },
{ 0, NULL }
};