Update patch set 9

Patch Set 9:

(5 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
changes/93/28993/meta
Gerrit User 1000159 2 months ago committed by Gerrit Code Review
parent 0b30270cfb
commit 03446e92ec
  1. 54
      577f20e7fe9f8a17ab3505ad2b983189390e8cfc
  2. 18
      df43910c8f6b3edfeb985f391b15632e04a75a41
  3. 21
      e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0

@ -17,6 +17,24 @@
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "fd1a1b1e_615cd34b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Done",
"parentUuid": "dd93c751_9be04fe6",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "b561a406_fc5010a7",
"filename": "src/socket.c",
"patchSetId": 8
},
"lineNbr": 208,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Done",
"parentUuid": "dda0b532_5a697daa",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -50,6 +86,24 @@
"message": "if you use an implementation like this here, we don\u0027t need to add osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations:\n\n\n struct osmo_strbuf sb \u003d { ... };\n if (i !\u003d 1)\n OSMO_STRBUF_PRINTF(sb, \"(\");\n for (...) {\n struct osmo_sockaddr_str ss;\n if (i)\n OSMO_STRBUF_PRINTF(sb, \"|\");\n osmo_sockaddr_str_from_str2(\u0026ss, hosts[i]);\n OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT, OSMO_SOCKADDR_STR_FMT_ARGS(\u0026ss));\n }\n if (i !\u003d 1)\n OSMO_STRBUF_PRINTF(sb, \")\");\n return sb.chars_needed;",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "b064f7de_37eaf3a4",
"filename": "src/socket.c",
"patchSetId": 8
},
"lineNbr": 211,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Done",
"parentUuid": "16eeb34d_42c05fa7",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

@ -34,6 +34,24 @@
"parentUuid": "f0224e4c_231aaeff",
"revId": "df43910c8f6b3edfeb985f391b15632e04a75a41",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "14293a14_3c048ce5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Done",
"parentUuid": "b6fc0b29_1b59f0eb",
"revId": "df43910c8f6b3edfeb985f391b15632e04a75a41",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bc4c4b5c_e36373ae",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-29T05:39:59Z",
"side": 1,
"message": "Updated static helper instead of creating new function as requested in feedback.",
"revId": "e2ac1a1b4c0f2b2674bf69a1ef0ee94dd4c404b0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}
Loading…
Cancel
Save