libosmocore/51bca4aefe0c5f406c31c0f279e7966f695e71ba

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "2ea82516_dd7c6159",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 1000004
      },
      "writtenOn": "2022-08-08T19:51:17Z",
      "side": 1,
      "message": "why exactly do we need this? Isn\u0027t sockaddr just some generic alias for all types of sockaddr? \n\nI guess you\u0027re worried that sokcaddr_storage might be larger than some of the other types and hence the other types (sockaddr_in, ...) cannot be type-cast + passed to the existing function for sockaddr_storage?",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ca8afec8_02b1d662",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 1000004
      },
      "writtenOn": "2022-08-08T19:52:58Z",
      "side": 1,
      "message": "I really don\u0027t see the point.  The new function is an exact copy of the old.  It\u0027s just the pointer type that differs.  But as the implementations are identical, calling the old function on a non-storage sockaddr is equally safe.  What am I missing?",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "27650d8d_e5ec23fb",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-08-09T09:47:42Z",
      "side": 1,
      "message": "Ideally the existing function should have been passed a \"struct sockaddr\" pointer, but it\u0027s not really an issue, a cast is expected there and that\u0027s totally usual in this context.",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "504ce11a_49618501",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-08-10T12:44:27Z",
      "side": 1,
      "message": "I\u0027ll update existing function instead in the next version.",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "76558c6b_76811d3f",
        "filename": "src/sockaddr_str.c",
        "patchSetId": 4
      },
      "lineNbr": 380,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2022-08-09T10:04:38Z",
      "side": 1,
      "message": "as far as I can see the guess is the only difference. Maybe the api doc can reflect that. Also or maybe update the existing function so that it is able to guess?",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "70fe1509_5c875e31",
        "filename": "src/sockaddr_str.c",
        "patchSetId": 4
      },
      "lineNbr": 380,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-08-10T12:44:27Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "76558c6b_76811d3f",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "90c5cc31_a578bec7",
        "filename": "src/sockaddr_str.c",
        "patchSetId": 4
      },
      "lineNbr": 385,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2022-08-09T10:04:38Z",
      "side": 1,
      "message": "the guess above dereferences src, in the case where src \u003d\u003d NULL, the function would have crashed already.",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b485c13f_e36e958e",
        "filename": "src/sockaddr_str.c",
        "patchSetId": 4
      },
      "lineNbr": 385,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-08-10T12:44:27Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "90c5cc31_a578bec7",
      "revId": "51bca4aefe0c5f406c31c0f279e7966f695e71ba",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}