osmocom
/
libosmo-sccp
mirror of https://gerrit.osmocom.org/libosmo-sccp
11
0
Fork 0
Code Issues Releases Wiki Activity

m3ua: Add some TODO comments on where we fall short of our potential 

Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e
This commit is contained in:
Harald Welte 2023-09-01 10:38:43 +02:00
parent b93e1d0120
commit 4c1751ddca
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/m3ua.c
View File

@ -462,9 +462,11 @@ static struct msgb *m3ua_to_msg(struct xua_msg *xua)
return NULL;
}
if (xua->hdr.msg_class == M3UA_MSGC_XFER)
if (xua->hdr.msg_class == M3UA_MSGC_XFER) {
/* TODO: M3UA RFC says that multiple different streams within the SCTP association
* *may* be used, for example, by using the SLS value. Not required but makes sense. */
msgb_sctp_stream(msg) = 1;
else
} else
msgb_sctp_stream(msg) = 0;
msgb_sctp_ppid(msg) = M3UA_PPID;

2
src/xua_as_fsm.c
View File

@ -158,6 +158,8 @@ int xua_as_transmit_msg(struct osmo_ss7_as *as, struct msgb *msg)
asp = xua_as_select_asp_override(as);
break;
case OSMO_SS7_AS_TMOD_LOADSHARE:
/* TODO: actually use the SLS value to ensure same SLS goes through same ASP. Not
* strictly required by M3UA RFC, but would fit the overall principle. */
case OSMO_SS7_AS_TMOD_ROUNDROBIN:
asp = xua_as_select_asp_roundrobin(as);
break;