osmocom
/
libosmo-sccp
mirror of https://gerrit.osmocom.org/libosmo-sccp
14
0
Fork 0
Code Issues Releases Wiki Activity

Don't use deprecated osmo_stream_cli_open2() 

Using osmo_stream_cli_open() with explicit timeout set via
osmo_stream_cli_set_reconnect_timeout() will have the same
effect. Update comment explaining this as well as the code.

Change-Id: Iffe6ea48a170880faef071c7c4a1bc0605aa9855
This commit is contained in:
Max 2019-02-07 11:06:15 +01:00
parent 81c6a0a979
commit 0a93a683f3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/osmo_ss7.c
View File

@ -1261,12 +1261,13 @@ int osmo_ss7_asp_restart(struct osmo_ss7_asp *asp)
else
osmo_stream_cli_set_read_cb(asp->client, xua_cli_read_cb);
osmo_stream_cli_set_data(asp->client, asp);
rc = osmo_stream_cli_open2(asp->client, 1);
rc = osmo_stream_cli_open(asp->client);
if (rc < 0) {
LOGSS7(asp->inst, LOGL_ERROR, "Unable to open stream"
" client for ASP %s\n", asp->cfg.name);
/* we don't return error in here because osmo_stream_cli_open2()
will continue to retry to connect so the error is transient */
/* we don't return error in here because osmo_stream_cli_open()
will continue to retry (due to timeout being explicitly set with
osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */
}
/* TODO: make this configurable and not implicit */
role = XUA_ASPFSM_ROLE_ASP;